Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize tags into Service struct #47

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

gautamg795
Copy link
Contributor

What problem are we solving?

get_service_nodes currently does not include a service's tags in the returned struct.

How are we solving the problem?

Just deserialize the tags into a Vec<String>; the data is already present in the response.

Checks

Please check these off before promoting the pull request to non-draft status.

  • All CI checks are green.
  • I have reviewed the proposed changes myself.

Copy link

github-actions bot commented Jul 11, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gautamg795
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@gautamg795 gautamg795 marked this pull request as ready for review July 11, 2024 20:10
@gautamg795
Copy link
Contributor Author

thanks for the quick review! I've fixed the failing tests; didn't realize the Consul config needed to be updated in the test config as well

@kushudai
Copy link
Contributor

thanks for the quick review! I've fixed the failing tests; didn't realize the Consul config needed to be updated in the test config as well

Thank you for the change!
Adding a field to a public type is a breaking change so I will need to make a minor version change for a release.
I should be able to get that out by next week.

@kushudai kushudai merged commit 1b4141a into Roblox:main Jul 12, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
@gautamg795 gautamg795 deleted the service-tags branch July 12, 2024 06:47
@gautamg795 gautamg795 restored the service-tags branch July 12, 2024 06:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants