[numpy] Fix constexpr auto name for dtype=object #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses compilation error for C++11
There was a problem hiding this comment.
Had missed this when merging in.
Not strictly necessary for the Drake bump.
@jwnimmer-tri You up for reviewing this one? (small change)
Reviewable status: 0 of 1 files reviewed, all discussions resolved
jwnimmer-tri
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @EricCousineau-TRI)
EricCousineau-TRI
merged commit c1b0cdd
into
RobotLocomotion:drake
32 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address current failure on
drake(5ffbae2), such as:https://github.com/RobotLocomotion/pybind11/actions/runs/6734247456/job/18304717857
This change is