-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary modifications to mavROS source build #324
base: main
Are you sure you want to change the base?
Conversation
I think you should be able to remove the MAVLink clone and modifications too. Vladimir pointed out the more recent version of mavlink-gdp-release, which releases binaries for Jazzy and Rolling, and includes the required version of pymavlink. The ROS Index also lists it as available here. |
24f0e3c
to
97e5617
Compare
This will end up closing #248 as well |
Performed a very cursory test this morning. The Docker image contains these Mavros/mavlink packages:
Unfortunately, I get the "yaml linkage" error for the Mavros
Looks like we need packages for Mavros 2.9 (which contains mavros#1994 ). |
I just did some tests and saw the same issue. Here are the binaries that I pulled: ros-rolling-mavros/now 2.8.0-1noble.20240919.231902 amd64 [installed,local]
MAVROS -- MAVLink extendable communication node for ROS with proxy for Ground Control Station.
ros-rolling-mavros-extras/now 2.8.0-1noble.20240919.234952 amd64 [installed,local]
Extra nodes and plugins for MAVROS.
ros-rolling-mavros-msgs/now 2.8.0-1noble.20240919.215846 amd64 [installed,local]
mavros_msgs defines messages for MAVROS. It looks like these binaries are older than those just recently released a few days ago. I don't see an updated build for Vladimir is pretty responsive. It might be worth just creating an issue and asking him to update the binaries for this |
Release 2.9 is out now. I need to do some testing to make sure that the binaries are available for install. EDIT: Do we need to wait for the next ROS sync for these packages? |
|
Changes Made
Removes the installation of mavros and mavlink from source.
Associated Issues
Testing
docker buildx bake --no-cache
builds.I'm remote right now, I have not been able to test the software in sim.