Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed useEffect dependencies in useMediaRecorder hook #582

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fixed useEffect dependencies in useMediaRecorder hook #582

wants to merge 1 commit into from

Conversation

sbsangu
Copy link

@sbsangu sbsangu commented Jun 1, 2024

Resolve useEffect dependencies in useMediaRecorder hook

Acceptance Criteria fulfillment

  • Include all necessary dependencies in the useEffect hook of the useMediaRecorder hook.
  • Ensure proper cleanup is performed when the component unmounts or when dependencies change.
  • Test that the lifecycle of the media recorder is managed correctly

Fixes #574

Video/Screenshots

Screenshot 2024-06-02 011323

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Spiral-Memory
Copy link
Collaborator

LGTM !
Can you please attach a video showing that both audio and video recorder is working fine after this change?

@Spiral-Memory
Copy link
Collaborator

Hey @sbsangu
Could you please upload a video showing everything works fine after this change?

@Spiral-Memory Spiral-Memory marked this pull request as draft October 6, 2024 10:33
@Spiral-Memory
Copy link
Collaborator

Screenshot_2024-10-06-16-02-23-46_e4424258c8b8649f6e67d283a50a2cbc

Camera not working !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spiral-Memory Spiral-Memory Spiral-Memory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: Missing Dependency in useEffect
3 participants
@sbsangu @CLAassistant @Spiral-Memory