fixed the disability issue while selecting emojis #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -42,7 +43,9 @@ const ChatInputFormattingToolbar = ({ | |||
|
|
|||
| const handleEmojiClick = (emojiEvent) => { | |||
| const [emoji] = emojiEvent.names; | |||
| messageRef.current.value += ` :${emoji.replace(/[\s-]+/g, '_')}: `; | |||
| const newValue = messageRef.current.value + ` :${emoji.replace(/[\s-]+/g, '_')}: `; | |||
There was a problem hiding this comment.
Thanks for your contribution, @smritidoneria.
LGTM! Can you please give a meaningful name to this variable instead of newValue?
|
I have the updated the name |
Spiral-Memory
approved these changes
Jul 23, 2024
|
Hey, do I have to make improvements in the pr or is it ready to get merge? |
|
It will be merged soon ! |
|
Hey @smritidoneria Please format your code using prettier |
|
done |
|
Any more changes required? |
sidmohanty11
approved these changes
Jul 25, 2024
| @@ -42,7 +43,10 @@ const ChatInputFormattingToolbar = ({ | |||
|
|
|||
| const handleEmojiClick = (emojiEvent) => { | |||
| const [emoji] = emojiEvent.names; | |||
| messageRef.current.value += ` :${emoji.replace(/[\s-]+/g, '_')}: `; | |||
| const updatedMessageWithEmoji = | |||
| messageRef.current.value + ` :${emoji.replace(/[\s-]+/g, '_')}: `; | |||
There was a problem hiding this comment.
i think it's complaining because of this
messageRef.current.value + ` :${emoji.replace(/[\s-]+/g, '_')}: `;
can we instead do
`${messageRef.current.value} :${emoji.replace(/[\s-]+/g, '_')}: `
also, can you check if messageRef.current.value can be other than a string? maybe we can add ?? '' if it's not present
smritidoneria
force-pushed
the
develop
branch
from
04a4859
to
2845951
Compare
smritidoneria
force-pushed
the
develop
branch
from
b9f7491
to
6e6c3b1
Compare
abhinavkrin
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
When selecting only emojis from the picker in the user input, the Send button now allows sending the emojis only.
Acceptance Criteria fulfillment
Fixes #608
Video/Screenshots
Screen.Recording.2024-07-23.at.10.06.38.AM.mov