Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate from field from Email Bridge #33713

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Oct 22, 2024

Proposed changes (including videos or screenshots)

Deprecates the from field from the apps.engine Email bridge to avoid misuse. Also, cloud workspaces require to have the from the same as defined in the settings, so we will get the value defined in the From_Email setting by default.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 22, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 2f27d19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/apps-engine Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 22, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33713/
on branch gh-pages at 2024-10-23 15:11 UTC

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (b59bedc) to head (2f27d19).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33713   +/-   ##
========================================
  Coverage    75.01%   75.01%           
========================================
  Files          480      480           
  Lines        21000    21000           
  Branches      5329     5329           
========================================
  Hits         15754    15754           
  Misses        4619     4619           
  Partials       627      627           
Flag Coverage Δ
unit 75.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tapiarafael tapiarafael marked this pull request as ready for review October 22, 2024 21:44
@tapiarafael tapiarafael requested a review from a team as a code owner October 22, 2024 21:44
Copy link
Contributor

@Gustrb Gustrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@tapiarafael tapiarafael added the stat: QA assured Means it has been tested and approved by a company insider label Oct 23, 2024
@tapiarafael tapiarafael added this to the 7.1.0 milestone Oct 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 23, 2024
@kodiakhq kodiakhq bot merged commit 82767d8 into develop Oct 23, 2024
52 checks passed
@kodiakhq kodiakhq bot deleted the chore/deprecate-from-field branch October 23, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants