[OP-25] Compound Selector with ::file-selector-button #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
There is an issue with compound selectors that have a child under
::file-selector-button
in it. It breaks the whole selectorDue to how the file selector button is styled, if you put a child selector in the button global style, it will break it.
E.G. Always styling icons within buttons with a certain color
Technically this is a breaking change though I suspect not many projects are styling the file selector button so it may not be an issue.
What Changed
Sanity Check
[ ] Have you updated any usage of changed tokens?[ ] Have you updated the docs with any component changes?[ ] Have you updated the dependency graph with any component changes?[ ] Do you need to update the package version?Screenshots