Enable proguard for the android app #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also disabled obfuscation. Since the app is open source, it doesn't really matter anyway. |
SirSaunders
approved these changes
Feb 9, 2018
|
gitignore conflicts |
|
Our app is not open source, fyi. But if our product was to provide customers with an SDK, then obfuscation would be of more benefit. Obfuscation can make debugging a real PITA, so IMHO you don't want to turn it on unless there is a compelling reason. |
|
Is there any reason this has not been merged yet? Are we waiting on something, or are we unsure about merging? |
|
Also, who is Sir Saunders? |
|
Sweet baby Jesus, this is a Rowan project. Better question: Who is Jason Hartley. My apologies. Carry on. |
|
Greetings from Rowan ACM 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the size of the app down from 4.3 MB to 2.8 MB. This is low enough to start using instant apps.