Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resample example #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wiccy46
Copy link

@wiccy46 wiccy46 commented Aug 15, 2023

The documentation is not obvious regarding how to resample an input.

@dvdsk
Copy link
Collaborator

dvdsk commented Apr 10, 2024

The sink will resample input for you when you append see:

.convert_samples();

This example is therefore resampling twice (once using UniformSourceIterator explicit and once implicit in sink). That does not make sense right?

A PR clarifying the docs for Sink::append might be a better way to address this. Cause I do agree it is very confusing and not obvious how input is resampled! Please, if you are willing, help improve the docs, we could really use the help.

@dvdsk dvdsk force-pushed the master branch 3 times, most recently from b10961c to a7f67b3 Compare October 10, 2024 00:14
@dvdsk dvdsk force-pushed the master branch 4 times, most recently from 0ee0413 to 073fdb1 Compare November 8, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants