adds upgrade guide draft (frame->span + stream open) #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrGlad
reviewed
Dec 23, 2024
UPGRADE.md
Outdated
| ## OutputStream | ||
| - The outputstream is now more configurable. Where you used `OutputStream::try_default()` you have a choice: | ||
| - *(recommended)* Get an error when the default stream could not be opened: `OutputStreamBuilder::open_default_stream()?` | ||
| - Keep the old behavior using: `OutputStreamBuilder::open_stream_or_fallback()`, which tries to open the default (audio) stream trying others when the default stream could not be opened. |
There was a problem hiding this comment.
I am always forgetting to mention this, but there is also a change in the fallback logic. Previous version either probed default settings of all devices or all settings of the default device. Current implementation tries all the combinations. I hope that does not break anything.
There was a problem hiding this comment.
I'll update the guide 👍
There was a problem hiding this comment.
take a look, if this is not right please let me know what you would write instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will point users who upgrade to the next rodio release to this document. It will help them upgrade (and save us a lot of confused users and issues).
I do not think I have missed anything. I suggest we merge this and then every PR that introduces a breaking change updates this document. I have already done that for still open PR #663.