Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds draft for maintainer guide #666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

adds draft for maintainer guide #666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions MAINTAINERS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Guidelines for maintainers (those with write access) of rodio. Note these are
guidelines not rules. Adhere to them as long as makes sense. This is a work in
progress document, more might follow as we get to know what works.

Please feel free to open an issue and discuss these if you have a suggestion.

1. Do not merge your own code to main, unless of course its a trivial change.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO such a rule is good if there is a large enough maintainer community behind it. In smaller projects, I think it is less viable. But if there is at least two maintainers where both are well available, why not.

For example spelling/grammar or fixing up a PR by someone else.
Loading