Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker image bug #18

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Marker image bug #18

merged 6 commits into from
Aug 13, 2024

Conversation

RyanBirtch-aot
Copy link
Owner

Description

This should fix the issue where the marker image is broken in the PR environment, I was able to get a fix for once the marker is placed. But when adding the marker in its "dragging" state, the image was still broken. I have rolled back the narrow solution and implemented a more general solution.

Types of changes

fix (a bug fix)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

Copy link
Collaborator

@abhilash-aot abhilash-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the marker image to point to leaflet folder . Looks good

@abhilash-aot abhilash-aot merged commit c3510da into feat-map Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants