Changes to the RFC part

SAP · Sep 12, 2023 · 3104915 · 3104915
1 parent 9938764
commit 3104915
Show file tree

Hide file tree

Showing 3 changed files with 85 additions and 35 deletions.
diff --git a/file-formats/cota/README.md b/file-formats/cota/README.md
@@ -1,5 +1,5 @@
 # COTA File Format
 
 File | Cardinality | Definition | Schema | Example
-:--- | :---  | :--- | :--- | :---
-`<name>.cota.json` | 1 | [`zif_aff_cota_v1.intf.abap`](./type/zif_aff_cota_v1.intf.abap) | [`cota-v1.json`](./cota-v1.json) |
+:--- | :--- | :--- | :--- | :---
+`<name>.cota.json` | 1 | [`zif_aff_cota_v1.intf.abap`](./type/zif_aff_cota_v1.intf.abap) | [`cota-v1.json`](./cota-v1.json)
diff --git a/file-formats/cota/cota-v1.json b/file-formats/cota/cota-v1.json
@@ -2,8 +2,8 @@
   "$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.",
   "$schema": "https://json-schema.org/draft/2020-12/schema",
   "$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/cota/cota-v1.json",
-  "title": "Connection Target Object",
-  "description": "Creation of connection target object",
+  "title": "Communication Target Object",
+  "description": "Creation of communication target object",
   "type": "object",
   "properties": {
     "formatVersion": {
@@ -80,8 +80,8 @@
           "default": "http"
         },
         "connectionTargetClass": {
-          "title": "Connection Target Class",
-          "description": "Connection target class",
+          "title": "Communication Target Class",
+          "description": "Communication target class",
           "type": "string",
           "maxLength": 30
         },
@@ -92,14 +92,25 @@
         },
         "clientIndependent": {
           "title": "Allow Client Independent Application Destinations",
-          "description": "Alow client independent application destinations",
+          "description": "Allow client independent application destinations",
           "type": "boolean"
         }
       },
-      "additionalProperties": false,
-      "required": [
-        "connectionTargetClass"
-      ]
+      "additionalProperties": false
+    },
+    "httpSettings": {
+      "title": "HTTP Settings",
+      "description": "HTTP settings",
+      "type": "object",
+      "properties": {
+        "pathPrefix": {
+          "title": "Path Prefix",
+          "description": "Path prefix",
+          "type": "string",
+          "maxLength": 100
+        }
+      },
+      "additionalProperties": false
     },
     "rfcSettings": {
       "title": "RFC Settings",
@@ -121,9 +132,9 @@
           ],
           "default": "synchronous"
         },
-        "enforceClassicRfc": {
-          "title": "Enforce Classic RFC",
-          "description": "Enforce classic RFC",
+        "enforceSapGuiSupport": {
+          "title": "Enforce SAP GUI Support",
+          "description": "Enforce SAP GUI support",
           "type": "boolean"
         },
         "enforceFastSerialization": {
@@ -132,15 +143,25 @@
           "type": "boolean"
         },
         "defaultCompressionMode": {
-          "title": "Use Default Compression Mode",
-          "description": "Use default compression mode",
-          "type": "boolean"
+          "title": "Default Compression Mode",
+          "description": "Default compression mode",
+          "type": "string",
+          "enum": [
+            "fast",
+            "high"
+          ],
+          "enumTitles": [
+            "Fast",
+            "High"
+          ],
+          "enumDescriptions": [
+            "Fast",
+            "High"
+          ],
+          "default": "fast"
         }
       },
-      "additionalProperties": false,
-      "required": [
-        "defaultCompressionMode"
-      ]
+      "additionalProperties": false
     }
   },
   "additionalProperties": false,

diff --git a/file-formats/cota/type/zif_aff_cota_v1.intf.abap b/file-formats/cota/type/zif_aff_cota_v1.intf.abap
@@ -26,19 +26,18 @@ INTERFACE zif_aff_cota_v1
       "! Communication type
       "! $default {@link zif_aff_cota_v1.data:co_comm_type.http}
       communication_type          TYPE ty_comm_type,
-      "! <p class="shorttext">Connection Target Class</p>
-      "! Connection target class
-      "! $required
+      "! <p class="shorttext">Communication Target Class</p>
+      "! Communication target class
       connection_target_class     TYPE zif_aff_types_v1=>ty_object_name_30,
       "! <p class="shorttext">Allow Multiple Application Destinations</p>
       "! Allow multiple application destinations
       allow_multiple_destinations TYPE abap_bool,
       "! <p class="shorttext">Allow Client Independent Application Destinations</p>
-      "! Alow client independent application destinations
+      "! Allow client independent application destinations
       client_independent          TYPE abap_bool,
     END OF ty_configuration.
 
-  "! <p class="shorttext">RFY Type</p>
+  "! <p class="shorttext">RFC Type</p>
   "! $values {@link zif_aff_cota_v1.data:co_rfctype}
   TYPES ty_rfctype TYPE c LENGTH 1.
 
@@ -51,6 +50,22 @@ INTERFACE zif_aff_cota_v1
       synchronous TYPE ty_rfctype VALUE 'X',
     END OF co_rfctype.
 
+  "! <p class="shorttext">Default Compression Mode</p>
+  "! $values {@link zif_aff_cota_v1.data:co_compress_mode}
+  TYPES ty_comp_mode TYPE c LENGTH 1.
+
+  CONSTANTS:
+    "! <p class="shorttext">Default Compression Mode</p>
+    "! Default compression mode
+    BEGIN OF co_compress_mode,
+      "! <p class="shorttext">Fast</p>
+      "! Fast
+      fast TYPE ty_comp_mode VALUE 'F',
+      "! <p class="shorttext">High</p>
+      "! High
+      high TYPE ty_comp_mode VALUE 'H',
+    END OF co_compress_mode.
+
   TYPES:
     "! <p class="shorttext">RFC Settings</p>
     "! RFC settings
@@ -60,21 +75,32 @@ INTERFACE zif_aff_cota_v1
       "! RFC type
       "! $default {@link zif_aff_cota_v1.data:co_rfctype.synchronous}
       rfc_type                   TYPE ty_rfctype,
-      "! <p class="shorttext">Enforce Classic RFC</p>
-      "! Enforce classic RFC
-      enforce_classic_rfc        TYPE abap_bool,
+      "! <p class="shorttext">Enforce SAP GUI Support</p>
+      "! Enforce SAP GUI support
+      enforce_sap_gui_support        TYPE abap_bool,
       "! <p class="shorttext">Enforce Fast Serialization</p>
       "! Enforce fast serialization
       enforce_fast_serialization TYPE abap_bool,
-      "! <p class="shorttext">Use Default Compression Mode</p>
-      "! Use default compression mode
-      "! $required
-      default_compression_mode   TYPE abap_bool,
+      "! <p class="shorttext">Default Compression Mode</p>
+      "! Default compression mode
+      "! $default {@link zif_aff_cota_v1.data:co_compress_mode.fast}
+      default_compression_mode   TYPE ty_comp_mode,
     END OF ty_rfc_settings.
 
   TYPES:
-    "! <p class="shorttext">Connection Target Object</p>
-    "! Creation of connection target object
+    "! <p class="shorttext">HTTP Settings</p>
+    "! HTTP settings
+    "! $required
+    BEGIN OF ty_http_settings,
+      "! <p class="shorttext">Path Prefix</p>
+      "! Path prefix
+      path_prefix TYPE zif_aff_types_v1=>ty_description_100,
+    END OF ty_http_settings.
+
+
+  TYPES:
+    "! <p class="shorttext">Communication Target Object</p>
+    "! Creation of communication target object
     BEGIN OF ty_main,
       "! <p class="shorttext">Format Version</p>
       "! Format version
@@ -88,6 +114,9 @@ INTERFACE zif_aff_cota_v1
       "! Configuration
       "! $required
       configuration  TYPE ty_configuration,
+      "! <p class="shorttext">HTTP Settings</p>
+      "! HTTP settings
+      http_settings  TYPE ty_http_settings,
       "! <p class="shorttext">RFC Settings</p>
       "! RFC settings
       rfc_settings   TYPE ty_rfc_settings,