Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interface names - remove prefix #153

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Update interface names - remove prefix #153

merged 2 commits into from
Aug 11, 2021

Conversation

wurzka
Copy link
Contributor

@wurzka wurzka commented Aug 4, 2021

Closes #151

@wurzka wurzka requested review from schneidermic0 and larshp August 4, 2021 13:17
@larshp
Copy link
Collaborator

larshp commented Aug 4, 2021

REPS + FUNC are not ABAP object types, as far as I know

@schneidermic0
Copy link
Contributor

FUNC + REPS are LIMU object types but no R3TR object types.

I have just talked to the experts. There is no overlap between LIMU and R3TR object types (even if the key of transport tables like TADIR or E071 make it look like that there is an overlap; PGMID is part of the object key).

This means we could use them uniquely in the system. However, this would mean for REPS that we should remove it from object type FUGR to a generic one that can also be used by other object types (e.g., module pools)

@larshp
Copy link
Collaborator

larshp commented Aug 4, 2021

okay, this leads back to question A in #146 (comment)

and I suggest reopening #128

in https://github.com/SAP/abap-file-formats/blob/main/doc/specification.md it mentions both "object type" and "sub object type", so as mentioned in "A" it seemed pretty clear that it was R3TR types

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation for sub object object types is changed in #154.

Therefore, the filenames for LIMU object types as well.

@wurzka wurzka merged commit 27ebf7d into main Aug 11, 2021
@wurzka wurzka deleted the update/interface-names branch August 11, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust object definition filenames
3 participants