Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Format for DDLX (CDS Metadata Extensions) #292

Merged
merged 5 commits into from
Feb 7, 2022
Merged

File Format for DDLX (CDS Metadata Extensions) #292

merged 5 commits into from
Feb 7, 2022

Conversation

BeckerWdf
Copy link
Contributor

No description provided.

@BeckerWdf
Copy link
Contributor Author

@albertmink: Can you tell me what's fron with the README.md file?
As far as I see it has only LF line endings and a new line at the end of the file.

@larshp
Copy link
Collaborator

larshp commented Jan 24, 2022

ref #161

@larshp
Copy link
Collaborator

larshp commented Jan 24, 2022

for what its worth, I suggest prioritizing finishing DDLS before adding DDLX

@BeckerWdf
Copy link
Contributor Author

for what its worth, I suggest prioritizing finishing DDLS before adding DDLX

We will handle the improvements of DDLS later.

@albertmink
Copy link
Contributor

@BeckerWdf, I agree. The file should be ok.

@BeckerWdf
Copy link
Contributor Author

@BeckerWdf, I agree. The file should be ok.

Can you please approve this PR?

Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's good to me.

@BeckerWdf
Copy link
Contributor Author

ref #161

Fix my last commit this should be fixed

@BeckerWdf BeckerWdf requested a review from larshp February 4, 2022 12:53
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@BeckerWdf
Copy link
Contributor Author

BeckerWdf commented Feb 7, 2022

@larshp: Does this look good to you?

@larshp
Copy link
Collaborator

larshp commented Feb 7, 2022

filename extension = acds is good

I have not looked through the details of the file format, should start fixing issues from the top of the list #148, DDLX is low on my list of priorities

@BeckerWdf BeckerWdf merged commit 3e177b8 into main Feb 7, 2022
@BeckerWdf BeckerWdf deleted the ddlx branch February 7, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants