Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAJC]: Add Parameters, Groups, Sections #538

Merged
merged 5 commits into from
Aug 1, 2023
Merged

[SAJC]: Add Parameters, Groups, Sections #538

merged 5 commits into from
Aug 1, 2023

Conversation

heichmann
Copy link
Contributor

No description provided.

schneidermic0
schneidermic0 reviewed Jun 26, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good to me. I have just some minor comments so far

file-formats/sajc/type/zif_aff_sajc_v1.intf.abap Show resolved Hide resolved
file-formats/sajc/type/zif_aff_sajc_v1.intf.abap Outdated Show resolved Hide resolved
@schneidermic0 schneidermic0 requested a review from a team July 3, 2023 12:43
wurzka
wurzka requested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX review has been performed. See my comments

file-formats/sajc/type/zif_aff_sajc_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/sajc/type/zif_aff_sajc_v1.intf.abap Show resolved Hide resolved
@schneidermic0 schneidermic0 requested a review from wurzka July 31, 2023 15:17
wurzka
wurzka approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@wurzka wurzka merged commit 9792b62 into SAP:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wurzka wurzka wurzka approved these changes

@schneidermic0 schneidermic0 schneidermic0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heichmann @schneidermic0 @wurzka