Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SWCR] Add new object type Software Component Relations #539

Merged
merged 17 commits into from
Aug 2, 2023
Merged

[SWCR] Add new object type Software Component Relations #539

merged 17 commits into from
Aug 2, 2023

Conversation

hottek
Copy link
Contributor

@hottek hottek commented Jun 30, 2023

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Jun 30, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

schneidermic0
schneidermic0 requested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hottek. Please find my comments/questions below.

file-formats/swcr/examples/z_aff_example_swcr.swcr.json Show resolved Hide resolved
file-formats/swcr/type/zif_aff_swcr_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/swcr/type/zif_aff_swcr_v1.intf.abap Outdated Show resolved Hide resolved
@schneidermic0
Copy link
Contributor

@hottek I have made some small changes to set the correct header and to solve the check failures (some of them I introduced by removing the description, some due to renaming the fields).

Would you double check whether the changes are fine, please?

@hottek
Copy link
Contributor Author

hottek commented Jul 5, 2023

@schneidermic0 Thank you, the changes look good to me.

@hottek hottek requested a review from schneidermic0 July 5, 2023 12:24
@hottek
Copy link
Contributor Author

hottek commented Jul 5, 2023

@schneidermic0 We came to the conclusion that we need all three ABAP Language Versions. I have changed the type of the abap_language_version field in the ty_header structure.

schneidermic0
schneidermic0 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hottek

Looks good to me.

@schneidermic0 schneidermic0 requested a review from a team July 5, 2023 13:04
schneidermic0
schneidermic0 requested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hottek.

I found only some minor issues

file-formats/swcr/type/zif_aff_swcr_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/swcr/type/zif_aff_swcr_v1.intf.abap Show resolved Hide resolved
schneidermic0
schneidermic0 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@schneidermic0 schneidermic0 requested a review from a team July 21, 2023 10:18
wurzka
wurzka requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We performed an UX Cross Check. I only found one issue regarding the descriptions. See my comments below.

file-formats/swcr/type/zif_aff_swcr_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/swcr/type/zif_aff_swcr_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/swcr/type/zif_aff_swcr_v1.intf.abap Outdated Show resolved Hide resolved
@hottek hottek requested a review from wurzka August 2, 2023 07:15
wurzka
wurzka approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@wurzka wurzka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hottek! LGTM :)

@wurzka wurzka merged commit b268edc into SAP:main Aug 2, 2023
7 checks passed
@hottek hottek mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wurzka wurzka wurzka approved these changes

@schneidermic0 schneidermic0 schneidermic0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hottek @schneidermic0 @wurzka