Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIPG] Add new object type UIPG #555

Merged
merged 17 commits into from
Oct 2, 2023
Merged

[UIPG] Add new object type UIPG #555

merged 17 commits into from
Oct 2, 2023

Conversation

HelgeCD
Copy link
Contributor

@HelgeCD HelgeCD commented Sep 7, 2023

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Sep 7, 2023

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Sep 7, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@wurzka wurzka self-requested a review September 11, 2023 09:09
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HelgeCD Thanks for your contribution. See my comments.

Please check your descriptions. In contrast to the title, they should be in sentence case.

file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @HelgeCD for your contribution.

I haven't had a look at this PR, yet because there were no reaction on @wurzka's feedback so far. But she asked me to have a look at it, too.

So, find my questions and comments below.

file-formats/uipg/examples/(ui2)flp_demo_page.uipg.json Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the improvements.

Find my comments below.

file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some typos. Otherwise it looks good to me.

file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/uipg/type/zif_aff_uipg_v1.intf.abap Outdated Show resolved Hide resolved
@schneidermic0 schneidermic0 requested a review from a team September 25, 2023 13:03
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We performed UX Review for UIPG. No further findings. Looks good to me! :)

@schneidermic0
Copy link
Contributor

@HelgeCD Welcome as contributor 👍

@schneidermic0 schneidermic0 merged commit e3fea79 into SAP:main Oct 2, 2023
8 checks passed
@wurzka
Copy link
Contributor

wurzka commented Oct 2, 2023

@HelgeCD I updated the 3 descriptions in the schema that you changed in your interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants