[SPRV] Sync of AFF in repo with dev #563
Conversation
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
| name TYPE c LENGTH 30, | ||
| "! <p class="shorttext">Prefix</p> | ||
| "! $showAlways | ||
| prvname TYPE c LENGTH 30, |
There was a problem hiding this comment.
We usually suggest to keep the title (shorttext) and the name of the component in sync.
So it would be
| prvname TYPE c LENGTH 30, | |
| provider_name TYPE c LENGTH 30, |
or even
| prvname TYPE c LENGTH 30, | |
| name TYPE c LENGTH 30, |
depending on the choice for the title
There was a problem hiding this comment.
I will change it to the first suggestion:
The provider name is the name of the provider proxy that is generated during save of the SPRV.
We do not display the SPRV name as it is also visible in the header of the selected object.
Using 'name' as a shorttext could be misleading as it is the name of the dependent provider and not of the selected object.
| "! $required | ||
| name TYPE c LENGTH 30, | ||
| "! <p class="shorttext">Prefix</p> | ||
| "! $showAlways |
There was a problem hiding this comment.
Field had been required before. Can this field be empty? If yes, showAlways is fine. If not, it should be required.
There was a problem hiding this comment.
The namespace is separated into two fields: Base and Suffix.
The namespace itself is mandatory but the base is hardcoded so the user can only enter the suffix in the wizard and we concatenate these fields. The concatenated namespace is required but this is made sure programmatically.
So the field is from my point of view only a "showAlways" for the display view.
| "! <p class="shorttext">Namespace</p> | ||
| "! Namespace of the service provider | ||
| "! $showAlways | ||
| prvns TYPE c LENGTH 30, |
There was a problem hiding this comment.
Again here, I suggest not to use an abbreviation
| prvns TYPE c LENGTH 30, | |
| namespace TYPE c LENGTH 30, |
AFF should be human readable.
There was a problem hiding this comment.
Changed to namespace
|
Suggestions fixed with pull request #566 |
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
There was a problem hiding this comment.
We can still change this object type incompatible. It hasn't been available, yet.
Looks good to me. Thanks @delucapietro for the update.
No description provided.