Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPRV] AFF fixes due to suggestions #566

Closed
wants to merge 2 commits into from
Closed

[SPRV] AFF fixes due to suggestions #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c468d54
AFF fixes due to suggestions
delucapietro Nov 7, 2023
385e2e7
Update file-formats/sprv/type/zif_aff_sprv_v1.intf.abap
delucapietro Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions file-formats/sprv/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# SPRV File Format

File | Cardinality | Definition | Schema | Example
:--- | :--- | :--- | :--- | :---
`<name>.sprv.json` | 1 | [`zif_aff_sprv_v1.intf.abap`](./type/zif_aff_sprv_v1.intf.abap) | [`sprv-v1.json`](./sprv-v1.json) |
:--- | :--- | :--- | :--- | :---
`<name>.sprv.json` | 1 | [`zif_aff_sprv_v1.intf.abap`](./type/zif_aff_sprv_v1.intf.abap) | [`sprv-v1.json`](./sprv-v1.json) | [srt_test_sprv.sprv.json](./examples/srt_test_sprv.sprv.json)
12 changes: 12 additions & 0 deletions file-formats/sprv/examples/srt_test_sprv.sprv.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"formatVersion": "1",
"header": {
"description": "SPRV-Objekt für SOAP-Laufzeit testen",
"originalLanguage": "en"
},
"serviceProvider": {
"providerName": "IIW_SRT_TEST_SPRV_PROVIDER",
"namespace": "urn:sap-com:sprx:ep:sap:test",
"prefix": ""
}
}
17 changes: 10 additions & 7 deletions file-formats/sprv/sprv-v1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,23 +61,26 @@
"description": "Service provider details",
"type": "object",
"properties": {
"name": {
"title": "Name",
"providerName": {
"title": "Provider Name",
"description": "Name of the service provider",
"type": "string",
"maxLength": 30
},
"namespace": {
"title": "Namespace",
"description": "Namespace of the service provider",
"type": "string",
"maxLength": 30
},
"prefix": {
"title": "Prefix",
"title": "Object Name Prefix",
"description": "Prefix for all generated objects",
"type": "string",
"maxLength": 10
}
},
"additionalProperties": false,
"required": [
"name"
]
"additionalProperties": false
}
},
"additionalProperties": false,
Expand Down
18 changes: 11 additions & 7 deletions file-formats/sprv/type/zif_aff_sprv_v1.intf.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,29 @@ INTERFACE zif_aff_sprv_v1
"! <p class="shorttext">Service Provider</p>
"! Service provider details
BEGIN OF ty_servprovider,
"! <p class="shorttext">Name</p>
"! <p class="shorttext">Provider Name</p>
"! Name of the service provider
"! $required
name TYPE c LENGTH 30,
"! <p class="shorttext">Prefix</p>
"! $showAlways
provider_name TYPE c LENGTH 30,
"! <p class="shorttext">Namespace</p>
"! Namespace of the service provider
"! $showAlways
namespace TYPE c LENGTH 30,
"! <p class="shorttext">Object Name Prefix</p>
"! Prefix for all generated objects
"! $showAlways
prefix TYPE c LENGTH 10,
prefix TYPE c LENGTH 10,
END OF ty_servprovider.
TYPES:
"! <p class="shorttext">SOAP Web Service Provider Model</p>
"! SOAP web service provider model
BEGIN OF ty_main,
"! $required
format_version TYPE zif_aff_types_v1=>ty_format_version,
format_version TYPE zif_aff_types_v1=>ty_format_version,
"! <p class="shorttext">Header</p>
"! Header data
"! $required
header TYPE zif_aff_types_v1=>ty_header_60_cloud,
header TYPE zif_aff_types_v1=>ty_header_60_cloud,
"! <p class="shorttext">Service Provider</p>
"! Service provider details
"! $required
Expand Down
Loading