[UIAD] Add new object type UIAD

[aaronbruchsap]

No description provided.

[cla-assistant]

All committers have signed the CLA.

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[wurzka]

Hi @aaronbruchsap,
thanks for contributing the UIAD to our repository. I went through your ABAP type and put some comments.
Don't be afraid of the number 😉 . Most of them are related to the title case. There are also some questions or suggestions for improvement we maybe want to discuss.

[wurzka]

Thanks again for your changes @aaronbruchsap! I just have one more question.
However, before merging, I would like to also have a review and feedback from @schneidermic0. Therefore, I put him as reviewer.

[albertmink]

Check fails due to SchemaStore/schemastore#3620

[schneidermic0]

@aaronbruchsap Thanks for all the updates.

Please find some questions and detailed suggestions below.

I am struggling a bit in making a proper proposal for the general structure. I don't see an option to provide a more flat structure. Depending on the tile types the list of tiles has still a deeply nested structure containing further arrays in array.

[ViktoriaFreidel]

Hi @aaronbruchsap, thanks for contributing the UIAD to our repository. I went through your ABAP type and put some comments. Don't be afraid of the number 😉 . Most of them are related to the title case. There are also some questions or suggestions for improvement we maybe want to discuss.

FYI: I think it is done.We commited new changed files and would like to use those for next UX-Review.

[albertmink]

Thanks and LGTM

we did the ux review together, so I overrole

[schneidermic0]

In general it looks good to me. I have just faced one question regarding default values for booleans.

Furthermore, following comment has not been answered, yet. This might lead to a change:
https://github.com/SAP/abap-file-formats/pull/586/files/89d45870b2fc419bbc31088d85ce266ef38c51e8..983a52c40896cb20f0041de140c213ddfbd99d39#r1521536216

[ViktoriaFreidel]

The correction for default value and some titles is done. New files for UIAD are ready for review.

[schneidermic0]

@ViktoriaFreidel Thank you very much for the update and removing the default.

Most probably the rename of fields make sense. I am wondering whether you can also adapt the field names. This will help users to find the correct field names in the JSON representation.

@SAP/abap-file-formats-ux Any concerns?

[ViktoriaFreidel]

I am not sur if my approvement is needed, just confirm review changes

[albertmink]

I just re-requested the review of @schneidermic0

[schneidermic0]

Looks good to me