-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIFD] Add new object type AIFD #612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my first comments/questions below.
Do you think it is possible to provide an example? I guess this will help us to review the object type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry for the late response. I did not manage to look into it earlier.
Thanks for providing the example. This was helpful for me. 👍
I try to first have a look at the general structure. Most probably I suggest to use different names, later as soon as you think the structure is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I understood your object's structure, now. This is fine for me.
I just found some minor issues/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open question has been clarified. Since I won't be available for the next two weeks, I will dismiss my review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adaption. Looks good to me, now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your update. Looks good to me.
}, | ||
"aifInterfaces":[ | ||
{ | ||
"interfaceObjectName":"INT_OBJ_1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@D047539 did you consider to change interfaceObjectName
to name
? Typically, the array name, here 'aifInterfaces', is sufficient and in particular if the array element contains a single String.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertmink no, we have not changed the name from interfaceObjectName to name because name is very generic one and from our point of view it is not a clear name. We would like to keep the interfaceObjectName as name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this has been suggested beforehand, I just wanted to make sure that this has been considered by you. You are allowed to overrule our suggestions 😐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
No description provided.