Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDCK] Add new object type for EDCK #629

Merged
merged 29 commits into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
0793f91
Add files for EDCK and EDCR
KUMARMUKULSAP Jul 1, 2024
09c7a8b
Abaplint fix
KUMARMUKULSAP Jul 3, 2024
ff8a25b
Abap lint fix for EDCR
KUMARMUKULSAP Jul 3, 2024
b2e6827
abap lint fix EDCR
KUMARMUKULSAP Jul 3, 2024
0ab59a3
abap lint fix
KUMARMUKULSAP Jul 3, 2024
1b106ad
abap lint fix
KUMARMUKULSAP Jul 3, 2024
faa0725
EDCR removed
KUMARMUKULSAP Jul 5, 2024
e1585fe
Fix providied for comments as recieved
KUMARMUKULSAP Aug 11, 2024
44bebfb
abap_lint type alignment fix
KUMARMUKULSAP Aug 11, 2024
aeb32d9
abaplint fixes
KUMARMUKULSAP Aug 11, 2024
2c6bb2a
abaplint tab fixes
KUMARMUKULSAP Aug 11, 2024
da26d69
abaplint Type alignment fix
KUMARMUKULSAP Aug 12, 2024
26f4cd6
Markus Review comments
KUMARMUKULSAP Sep 5, 2024
b6d94e8
abap_lint fixes
KUMARMUKULSAP Sep 5, 2024
e207830
abap_lint fix
KUMARMUKULSAP Sep 5, 2024
89bf13b
EOL fixes
KUMARMUKULSAP Sep 5, 2024
429c803
compare generated schema fix
KUMARMUKULSAP Sep 5, 2024
b5c941d
EOL fix
KUMARMUKULSAP Sep 5, 2024
0ae7a95
EOL fix
KUMARMUKULSAP Sep 5, 2024
21472e2
EOL fix
KUMARMUKULSAP Sep 5, 2024
fd15549
Generated JSON Schema error
KUMARMUKULSAP Sep 5, 2024
782d3b1
generated schema issue
KUMARMUKULSAP Sep 5, 2024
0a38384
Markus review comments
KUMARMUKULSAP Sep 6, 2024
a5ed858
Constant name change
KUMARMUKULSAP Sep 10, 2024
bf4cd53
Merge branch 'main' into feature/edck
schneidermic0 Sep 10, 2024
9b78aad
Katharina's comment
KUMARMUKULSAP Sep 27, 2024
f04e13c
Fixes of Result Derived field
KUMARMUKULSAP Sep 27, 2024
622f276
Merge branch 'main' into feature/edck
wurzka Sep 27, 2024
cea6853
Merge branch 'main' into feature/edck
schneidermic0 Oct 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions file-formats/edck/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# EDCK File Format

File | Cardinality | Definition | Schema | Example
:--- | :--- | :--- | :--- | :---
`<name>.edck.json` | 1 | [`zif_aff_edck_v1.intf.abap`](./type/zif_aff_edck_v1.intf.abap) | [`edck-v1.json`](./edck-v1.json) | [`z_aff_example_edck.edck.json`](./examples/z_aff_example_edck.edck.json)
124 changes: 124 additions & 0 deletions file-formats/edck/edck-v1.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
{
"$comment": "This file is autogenerated, do not edit manually, see https://github.com/SAP/abap-file-formats for more information.",
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "https://github.com/SAP/abap-file-formats/blob/main/file-formats/edck/edck-v1.json",
"title": "Consistency Check ID",
"description": "Consistency check ID",
"type": "object",
"properties": {
"formatVersion": {
"title": "ABAP File Format Version",
"description": "The ABAP file format version",
"type": "string",
"const": "1"
},
"header": {
"title": "Header",
"description": "Header",
"type": "object",
"properties": {
"description": {
"title": "Description",
"description": "Description of the ABAP object",
"type": "string",
"maxLength": 60
},
"originalLanguage": {
"title": "Original Language",
"description": "Original language of the ABAP object",
"type": "string",
"minLength": 2
},
"abapLanguageVersion": {
"title": "ABAP Language Version",
"description": "ABAP language version",
"type": "string",
"enum": [
"standard",
"cloudDevelopment"
],
"enumTitles": [
"Standard",
"ABAP Cloud Development"
],
"enumDescriptions": [
"Standard",
"ABAP cloud development"
],
"default": "standard"
}
},
"additionalProperties": false,
"required": [
"description",
"originalLanguage"
]
},
"generalInformation": {
"title": "General Information",
"description": "General information of consistency check ID",
"type": "object",
"properties": {
"checkCategory": {
"title": "Check Category",
"description": "Consistency check category",
"type": "string",
"enum": [
"existenceCheck",
"statusCheck",
"edocumentExistenceCheck",
"contentMismatchCheck"
],
"enumTitles": [
"Existence Check",
"Status Check",
"Edocument Existence Check",
"Content Mismatch Check"
],
"enumDescriptions": [
"Existence check",
"Status check",
"Edocument existence check",
"Content mismatch check"
]
},
"checkIdClassification": {
"title": "Check Classification",
"description": "Consistency check ID classification",
"type": "string",
"enum": [
"core",
"additional"
],
"enumTitles": [
"Core delivered checks",
"Additionally (Extended) implemented checks"
],
"enumDescriptions": [
"Core delivered checks",
"Additionally (Extended) implemented checks"
],

Check failure on line 100 in file-formats/edck/edck-v1.json

View workflow job for this annotation

GitHub Actions / Compare generated against provided

]
"default": "core"
},
"checkClass": {
"title": "Additional Check Class",
"description": "Consistency check class",
"type": "string",
"maxLength": 30
},
"resultDerivationIndicator": {
"title": "Result Derivation Indicator",
"description": "Result process derived by BAdI",
"type": "boolean"
}
},
"additionalProperties": false
}
},
"additionalProperties": false,
"required": [
"formatVersion",
"header",
"generalInformation"
]
}
Binary file added file-formats/edck/examples/.DS_Store
Binary file not shown.
13 changes: 13 additions & 0 deletions file-formats/edck/examples/z_aff_example_edck.edck.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"formatVersion": "1",
"header": {
"description": "Example Check ID",
"originalLanguage": "en",
"abapLanguageVersion": "cloudDevelopment"
},
"generalInformation": {
"checkCategory": "existenceCheck",
"checkIdClassification": "core",
"resultDerivationIndicator": false
}
}
72 changes: 72 additions & 0 deletions file-formats/edck/type/zif_aff_edck_v1.intf.abap
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
INTERFACE zif_aff_edck_v1
PUBLIC.

TYPES ty_check_classification TYPE c LENGTH 1.
TYPES ty_check_category TYPE c LENGTH 6.

TYPES:
BEGIN OF ty_attributes,
"! <p class="shorttext">Check Category</p>
"! Consistency check category
"! $values {@link zif_aff_edck_v1.data:co_check_category}
"! $default {@link if_aff_edck_v1.data:co_check_category.exist}
Markus1812 marked this conversation as resolved.
Show resolved Hide resolved
check_category TYPE ty_check_category,
"! <p class="shorttext">Check Classification</p>
"! Consistency check ID classification
"! $values {@link zif_aff_edck_v1.data:co_check_classification}
"! $default {@link if_aff_edck_v1.data:co_check_classification.core}
Markus1812 marked this conversation as resolved.
Show resolved Hide resolved
check_id_classification TYPE ty_check_classification,
"! <p class="shorttext">Additional Check Class</p>
"! Consistency check class
check_class TYPE zif_aff_types_v1=>ty_object_name_30,
wurzka marked this conversation as resolved.
Show resolved Hide resolved
"! <p class="shorttext">Result Derivation Indicator</p>
"! Result process derived by BAdI
result_derivation_indicator TYPE abap_bool,
wurzka marked this conversation as resolved.
Show resolved Hide resolved
END OF ty_attributes.

TYPES:
"! <p class="shorttext">Consistency Check ID</p>
"! Consistency check ID
BEGIN OF ty_main,
"! $required
format_version TYPE zif_aff_types_v1=>ty_format_version,
"! <p class="shorttext">Header</p>
"! Header
"! $required
header TYPE zif_aff_types_v1=>ty_header_60_cloud,
"! <p class="shorttext">General Information</p>
"! General information of consistency check ID
"! $required
general_information TYPE ty_attributes,
END OF ty_main.

CONSTANTS:
"! <p class="shorttext">Check Classification</p>
"! Check classification
BEGIN OF co_check_classification,
"! <p class="shorttext">Core delivered checks</p>
Markus1812 marked this conversation as resolved.
Show resolved Hide resolved
"! Core delivered checks
core TYPE ty_check_classification VALUE 'C',
"! <p class="shorttext">Additionally (Extended) implemented checks</p>
Markus1812 marked this conversation as resolved.
Show resolved Hide resolved
"! Additionally (Extended) implemented checks
Markus1812 marked this conversation as resolved.
Show resolved Hide resolved
additional TYPE ty_check_classification VALUE 'A',
END OF co_check_classification.

CONSTANTS:
"! <p class="shorttext">Check Category</p>
"! Check category
BEGIN OF co_check_category,
"! <p class="shorttext">Existence Check</p>
"! Existence check
existence_check TYPE ty_check_category VALUE 'EXIST',
"! <p class="shorttext">Status Check</p>
"! Status check
status_check TYPE ty_check_category VALUE 'STATUS',
"! <p class="shorttext">Edocument Existence Check</p>
"! Edocument existence check
edocument_existence_check TYPE ty_check_category VALUE 'EDOCHK',
"! <p class="shorttext">Content Mismatch Check</p>
"! Content mismatch check
content_mismatch_check TYPE ty_check_category VALUE 'CONMIS',
END OF co_check_category.
ENDINTERFACE.
7 changes: 7 additions & 0 deletions file-formats/edck/type/zif_aff_edck_v1.intf.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"formatVersion": "1",
"header": {
"description": "AFF type for EDCK",
"originalLanguage": "en"
}
}
Loading