fix(core): remove role="dialog" from dialog body in docs (#12550)

SAP · Oct 18, 2024 · 42a2589 · 42a2589
1 parent 9a2dc67
commit 42a2589
Show file tree

Hide file tree

Showing 14 changed files with 14 additions and 15 deletions.
diff --git a/libs/docs/core/dialog/dialog-docs.component.html b/libs/docs/core/dialog/dialog-docs.component.html
@@ -221,7 +221,7 @@ <h1 fd-title id="fd-dialog-header-11">Playground Dialog</h1>
             <button fd-dialog-close-button (click)="dialog.dismiss()" title="close"></button>
         </fd-dialog-header>
         <fd-dialog-body>
-            <p id="fd-dialog-body-11" role="dialog">This is the dialog playground body text!</p>
+            <p id="fd-dialog-body-11">This is the dialog playground body text!</p>
         </fd-dialog-body>
         <fd-dialog-footer>
             <fd-button-bar fdType="emphasized" label="Close" (click)="dialog.close()" ariaLabel="Close Emphasized">

diff --git a/libs/docs/core/dialog/examples/auto-label/auto-label-dialog-example.component.html b/libs/docs/core/dialog/examples/auto-label/auto-label-dialog-example.component.html
@@ -5,7 +5,7 @@ <h1 id="fd-dialog-header-10" fd-title fd-dialog-title>The History of Pineapple</
         </fd-dialog-header>
 
         <fd-dialog-body>
-            <div id="fd-dialog-body-10" role="dialog">Are you interested in The Great History of Pineapple?</div>
+            <div id="fd-dialog-body-10">Are you interested in The Great History of Pineapple?</div>
         </fd-dialog-body>
 
         <fd-dialog-footer>

diff --git a/libs/docs/core/dialog/examples/component-based/dialog-example.component.ts b/libs/docs/core/dialog/examples/component-based/dialog-example.component.ts
@@ -20,7 +20,7 @@ import { TitleComponent } from '@fundamental-ngx/core/title';
                 <h1 id="fd-dialog-header-1" fd-title>{{ dialogRef.data.title }}</h1>
             </fd-dialog-header>
             <fd-dialog-body>
-                <p id="fd-dialog-body-1" role="dialog" [ngStyle]="{ 'text-align': 'justify', margin: 0 }">
+                <p id="fd-dialog-body-1" [ngStyle]="{ 'text-align': 'justify', margin: 0 }">
                     {{ dialogRef.data.pinnapleDescription }}
                 </p>
                 <ul [style.margin-bottom]="0">

diff --git a/...ialog/examples/dialog-backdrop-container/dialog-backdrop-container-example.component.html b/...ialog/examples/dialog-backdrop-container/dialog-backdrop-container-example.component.html
@@ -14,7 +14,7 @@ <h1 id="fd-dialog-header-2" fd-title>Backdrop Configuration</h1>
         </fd-dialog-header>
 
         <fd-dialog-body>
-            <div id="fd-dialog-body-2" role="dialog">{{ dialog.data }}</div>
+            <div id="fd-dialog-body-2">{{ dialog.data }}</div>
         </fd-dialog-body>
 
         <fd-dialog-footer>

diff --git a/...ocs/core/dialog/examples/dialog-configuration/dialog-configuration-example.component.html b/...ocs/core/dialog/examples/dialog-configuration/dialog-configuration-example.component.html
@@ -5,7 +5,7 @@ <h1 id="fd-dialog-header-4" fd-title>Origin of the Pineapple Word</h1>
         </fd-dialog-header>
 
         <fd-dialog-body>
-            <div id="fd-dialog-body-4" role="dialog">
+            <div id="fd-dialog-body-4">
                 The word pineapple in English was first recorded in 1398, when it was originally used to describe the
                 reproductive organs of conifer trees (now termed pine cones). When European explorers discovered this
                 tropical fruit they called them pineapples (term first recorded in that sense in 1664) because of their

diff --git a/libs/docs/core/dialog/examples/dialog-full-screen/dialog-full-screen-example.component.html b/libs/docs/core/dialog/examples/dialog-full-screen/dialog-full-screen-example.component.html
@@ -2,7 +2,7 @@
 <button fd-button label="Open Dialog From Object" (click)="openDialog()"></button>
 
 <ng-template #dialogContent>
-    <div [style.padding]="'0 1rem'" role="dialog">You can also create dialog without building whole template.</div>
+    <div [style.padding]="'0 1rem'">You can also create dialog without building whole template.</div>
 </ng-template>
 
 <ng-template #dialogSubHeader>
@@ -30,7 +30,7 @@ <h1 id="fd-dialog-header-10" fd-title>The History of Pineapple</h1>
         </fd-dialog-header>
 
         <fd-dialog-body>
-            <p id="fd-dialog-body-10" role="dialog">Are you interested in The Great History of Pineapple?</p>
+            <p id="fd-dialog-body-10">Are you interested in The Great History of Pineapple?</p>
         </fd-dialog-body>
 
         <fd-dialog-footer>

diff --git a/libs/docs/core/dialog/examples/dialog-full-screen/dialog-full-screen-example.component.ts b/libs/docs/core/dialog/examples/dialog-full-screen/dialog-full-screen-example.component.ts
@@ -40,7 +40,6 @@ import { TitleComponent } from '@fundamental-ngx/core/title';
         <fd-dialog-body>
             <p
                 id="fd-dialog-body-1"
-                role="dialog"
                 [ngStyle]="{
                     'text-align': 'justify',
                     margin: 0

diff --git a/libs/docs/core/dialog/examples/dialog-mobile/dialog-mobile-example.component.html b/libs/docs/core/dialog/examples/dialog-mobile/dialog-mobile-example.component.html
@@ -5,7 +5,7 @@ <h1 id="fd-dialog-header-5" fd-title>Wild pineapples</h1>
         </fd-dialog-header>
 
         <fd-dialog-body>
-            <div id="fd-dialog-body-5" role="dialog">
+            <div id="fd-dialog-body-5">
                 Certain bat-pollinated wild pineapples, members of the Bromeliad family, do the exact opposite of most
                 flowers by opening their flowers at night and closing them during the day.
             </div>

diff --git a/libs/docs/core/dialog/examples/dialog-object-example/dialog-object-example.component.html b/libs/docs/core/dialog/examples/dialog-object-example/dialog-object-example.component.html
@@ -1,7 +1,7 @@
 <button fd-button label="Open Dialog From Object" (click)="openDialog()"></button>
 
 <ng-template #dialogContent>
-    <div [style.padding]="'0 1rem'" role="dialog">You can also create dialog without building whole template.</div>
+    <div [style.padding]="'0 1rem'">You can also create dialog without building whole template.</div>
 </ng-template>
 
 <ng-template #dialogSubHeader>

diff --git a/libs/docs/core/dialog/examples/dialog-position/dialog-position-example.component.html b/libs/docs/core/dialog/examples/dialog-position/dialog-position-example.component.html
@@ -5,7 +5,7 @@ <h1 id="fd-dialog-header-6" fd-title>More Facts about the Pineapple</h1>
         </fd-dialog-header>
 
         <fd-dialog-body>
-            <div id="fd-dialog-body-6" role="dialog">
+            <div id="fd-dialog-body-6">
                 The natural (or most common) pollinator of the pineapple is the hummingbird. Pollination is required for
                 seed formation; the presence of seeds negatively affects the quality of the fruit. In Hawaii, where
                 pineapple is cultivated on an agricultural scale, importation of hummingbirds is prohibited for this

diff --git a/libs/docs/core/dialog/examples/dialog-state/dialog-state-example.component.html b/libs/docs/core/dialog/examples/dialog-state/dialog-state-example.component.html
@@ -5,7 +5,7 @@ <h1 id="fd-dialog-header-7" fd-title>Dialog states</h1>
         </fd-dialog-header>
 
         <fd-dialog-body>
-            <div id="fd-dialog-body-7" role="dialog">{{ dialog.data }}</div>
+            <div id="fd-dialog-body-7">{{ dialog.data }}</div>
         </fd-dialog-body>
 
         <fd-dialog-footer>

diff --git a/libs/docs/core/dialog/examples/stacked-dialogs/first-dialog-example.component.ts b/libs/docs/core/dialog/examples/stacked-dialogs/first-dialog-example.component.ts
@@ -24,7 +24,7 @@ import { SecondDialogExampleComponent } from './second-dialog-example.component'
             </fd-dialog-header>
 
             <fd-dialog-body>
-                <div id="fd-dialog-body-8" role="dialog">
+                <div id="fd-dialog-body-8">
                     This is the first dialog!<br />
                     Click the button below to open the second dialog.
                 </div>

diff --git a/libs/docs/core/dialog/examples/stacked-dialogs/second-dialog-example.component.ts b/libs/docs/core/dialog/examples/stacked-dialogs/second-dialog-example.component.ts
@@ -15,7 +15,7 @@ import { TitleComponent } from '@fundamental-ngx/core/title';
             </fd-dialog-header>
 
             <fd-dialog-body>
-                <div id="fd-dialog-body-9" role="dialog">
+                <div id="fd-dialog-body-9">
                     This is the second dialog!<br />
                     It is completely independent from the first dialog and can be controlled separately!
                 </div>

diff --git a/libs/docs/core/dialog/examples/template-based/template-based-dialog-example.component.html b/libs/docs/core/dialog/examples/template-based/template-based-dialog-example.component.html
@@ -5,7 +5,7 @@ <h1 id="fd-dialog-header-10" fd-title>The History of Pineapple</h1>
         </fd-dialog-header>
 
         <fd-dialog-body>
-            <p id="fd-dialog-body-10" role="dialog">Are you interested in The Great History of Pineapple?</p>
+            <p id="fd-dialog-body-10">Are you interested in The Great History of Pineapple?</p>
         </fd-dialog-body>
 
         <fd-dialog-footer>