Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): Recheck loadingState before refocus table cell #12517

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

CSEHoangV
Copy link
Contributor

@CSEHoangV CSEHoangV commented Oct 7, 2024

Related Issue(s)

closes #12450

Description

Issue: We have a listener on tableLoading to perform cell refocus whenever loadingState is false. However, this is executed asynchronously in setTimeout. Since table loading can be triggered either from internal or provided by application through [loading], there is a chance that it still runs when loadingState is true. For example, loadingState is set true from application when fetching the table and busy indicator is displayed on UI and scrollIntoView from focusCell will use busy indicator instead of table for position recalculation which gives the wrong position to scroll the table.

Solution: Add loadingState recheck to ensure that the code is only run when table is not loading.

@CSEHoangV CSEHoangV added the ng15 Angular 15 support label Oct 7, 2024
@CSEHoangV CSEHoangV self-assigned this Oct 7, 2024
Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 929e403
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/670577ad47b9d20008b4a0c1
😎 Deploy Preview https://deploy-preview-12517--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 7, 2024

Visit the preview URL for this PR (updated for commit 929e403):

https://fundamental-ngx-gh--pr12517-fix-ng15-platform-ta-btejmtgr.web.app

(expires Fri, 11 Oct 2024 18:27:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@CSEHoangV CSEHoangV closed this Oct 7, 2024
@CSEHoangV CSEHoangV reopened this Oct 7, 2024
@droshev droshev added this to the Sprint 139 - October 2024 milestone Oct 7, 2024
@CSEHoangV CSEHoangV linked an issue Oct 7, 2024 that may be closed by this pull request
@CSEHoangV CSEHoangV force-pushed the fix/ng15-platform-table-refocus branch from f0b43b9 to 929e403 Compare October 8, 2024 18:19
@mikerodonnell89 mikerodonnell89 merged commit 0831c29 into ng-15-downport Oct 8, 2024
19 checks passed
@mikerodonnell89 mikerodonnell89 deleted the fix/ng15-platform-table-refocus branch October 8, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ng15 Angular 15 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[P2][Sourcing] Platform table switch focus with custom indicator
4 participants