fix:remove code to populate cart id to spartacus storefront(#18920) (#…

…18920) Co-authored-by: I746264 <[email protected]> Co-authored-by: Scar Ai <[email protected]>
SAP · Jun 6, 2024 · 9739878 · 9739878
1 parent 7698fa2
commit 9739878
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 25 deletions.
diff --git a/feature-libs/asm/components/asm-bind-cart/asm-bind-cart.component.html b/feature-libs/asm/components/asm-bind-cart/asm-bind-cart.component.html
@@ -13,7 +13,6 @@
       formcontrolname="cartNumber"
       [formControl]="cartId"
       (keydown.enter)="bindCartToCustomer()"
-      (blur)="resetInput()"
       [attr.aria-label]="'asm.bindCart.enterCartId' | cxTranslate"
     />
     <button

diff --git a/feature-libs/asm/components/asm-bind-cart/asm-bind-cart.component.spec.ts b/feature-libs/asm/components/asm-bind-cart/asm-bind-cart.component.spec.ts
@@ -213,12 +213,6 @@ describe('AsmBindCartComponent', () => {
     spyOn(featureConfig, 'isLevel').and.returnValue(true);
   });
 
-  it('should fill the cart field with the current active cart for the customer', () => {
-    fixture.detectChanges();
-
-    expect(component.cartId.value).toEqual(prevActiveCartId);
-  });
-
   it('should leave the cart field blank when there is no current active cart for the customer', () => {
     (activeCartFacade.getActiveCartId as jasmine.Spy).and.returnValue(of(''));
 
@@ -227,16 +221,6 @@ describe('AsmBindCartComponent', () => {
     expect(component.cartId.value).toEqual('');
   });
 
-  it('should reset the input with the active cart ID when left empty', () => {
-    fixture.detectChanges();
-    let input = fixture.debugElement.query(By.css('input'));
-
-    component.cartId.setValue('');
-    input.triggerEventHandler('blur');
-
-    expect(component.cartId.value).toEqual(prevActiveCartId);
-  });
-
   it('should clear field when clear input is clicked', () => {
     fixture.detectChanges();
     let button = fixture.debugElement.query(By.css('.cx-asm-reset'));

diff --git a/feature-libs/asm/components/asm-bind-cart/asm-bind-cart.component.ts b/feature-libs/asm/components/asm-bind-cart/asm-bind-cart.component.ts
@@ -109,17 +109,10 @@ export class AsmBindCartComponent implements OnInit, OnDestroy {
     this.subscription.add(
       this.activeCartFacade.getActiveCartId().subscribe((response) => {
         this.activeCartId = response ?? '';
-        this.cartId.setValue(this.deepLinkCartId || this.activeCartId);
       })
     );
   }
 
-  resetInput() {
-    if (!this.cartId.value) {
-      this.cartId.setValue(this.activeCartId);
-    }
-  }
-
   /**
    * Bind the input cart number to the customer
    */
@@ -292,7 +285,9 @@ export class AsmBindCartComponent implements OnInit, OnDestroy {
             this.deepLinkCartId = this.asmComponentService?.getSearchParameter(
               'cartId'
             ) as string;
-            this.cartId.setValue(this.deepLinkCartId);
+            if (cartType === 'inactive') {
+              this.cartId.setValue(this.deepLinkCartId);
+            }
             this.asmComponentService?.setShowDeeplinkCartInfoAlert(true);
             this.asmComponentService?.handleDeepLinkNavigation();
           }