fix: (CXSPA-7944) - Storefinder input placeholder text #19324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pio-Bar
changed the title
spartacus
|
||||||||||||||||||||||||
| Project |
spartacus
|
| Run status |
|
| Run duration | 04m 17s |
| Commit |
|
| Committer | PioBar |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Zeyber
approved these changes
Oct 4, 2024
developpeurweb
approved these changes
Oct 9, 2024
Merge Checks Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CXSPA-7944
This one is a mildlyinteresting case. This is a problem inside JAWS itself and has been reported back in 2021 already.
In short, in input placeholders some characters get escaped by JAWS into a backslash. We should keep this in mind if we encounter this issue again. There is no way for us around it so, let's go with the suggestion of just avoiding the comma.