Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major dependency update #4806

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Major dependency update #4806

wants to merge 7 commits into from

Conversation

axelstudios
Copy link
Member

@axelstudios axelstudios commented Sep 19, 2024

What's this PR do?

  • Updates nearly all Python dependencies (except Django, and ones that rely on newer versions of Django/Python)
  • Adds a manage.py flush_db command that wipes all database contents (and restarts table sequences) except for static tables (EEEJ and Uniformat)
  • Removes vestigial django-autoslug dependency
  • Removes unused code/files
  • Removes deprecated NullBooleanField
  • Fixes sphinx spelling issues
  • Fixes sphinx-build on Windows
  • Updates tests
  • Fixed the following errors when visiting the Swagger page
    • <class 'seed.views.v3.sensors.SensorViewSet'> is not compatible with schema generation
    • <class 'seed.views.v3.tax_lot_properties.TaxLotPropertyViewSet'> is not compatible with schema generation

How should this be manually tested?

Monkey test, tests should pass

@axelstudios axelstudios added DO NOT MERGE Maintenance Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label. labels Sep 19, 2024
@axelstudios axelstudios marked this pull request as draft September 19, 2024 20:03
@axelstudios axelstudios force-pushed the task/dependency-update branch 7 times, most recently from f2a92e2 to 4b1a23b Compare September 20, 2024 18:37
@axelstudios axelstudios marked this pull request as ready for review September 20, 2024 20:09
@@ -13,6 +13,9 @@


class SensorViewSet(generics.GenericAPIView, viewsets.ViewSet, OrgMixin, ProfileIdMixin):
# For the Swagger page, GenericAPIView asserts a value exists for `queryset`
queryset = Sensor.objects.none()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why none and not all? I see mostly alls in the existing codebase.

@@ -1076,7 +1076,7 @@ def test_get_location(self):
location, status = _get_location(self.property_view)
self.assertEqual(status, "success")
self.assertTrue(location is not None)
self.assertEqual(location, "730 Garcia Street, Boring, Oregon, 97080")
self.assertEqual(location, "1070 Hunt Street, Boring, Oregon, 97015")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants