Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create windows .exe bundle with PyInstaller #92

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

nepstad
Copy link
Contributor

@nepstad nepstad commented Dec 17, 2020

No description provided.

Copy link
Contributor

@tankefugl tankefugl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintly has detected code quality issues in this pull request.

Copy link
Contributor

@tankefugl tankefugl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintly has detected code quality issues in this pull request.

Copy link
Contributor

@tankefugl tankefugl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintly has detected code quality issues in this pull request.

@WillRNaylor
Copy link
Collaborator

This is hard to test, as I don't have pip for cmd on windows (I just use anaconda). I assume you have to install a sort of "system" python and pip, rather than use anaconda. Is this sensible? Should we be using the conda pyinstaller instead then?

I note that I am just asking these questions, not just trying to imply that we should not use pip directly on windows.

@emlynjdavies
Copy link
Contributor

This is hard to test, as I don't have pip for cmd on windows (I just use anaconda). I assume you have to install a sort of "system" python and pip, rather than use anaconda. Is this sensible? Should we be using the conda pyinstaller instead then?

I note that I am just asking these questions, not just trying to imply that we should not use pip directly on windows.

My computer ran the generate_exe.bat from within the silcam environment. The silcam environment also uses pip, so it should still work if you are able to install the silcam environment.

@emlynjdavies emlynjdavies added the enhancement New feature or request label Dec 22, 2020
@emlynjdavies emlynjdavies linked an issue Dec 22, 2020 that may be closed by this pull request
@emlynjdavies
Copy link
Contributor

Some machines were able to create exe's that function correctly, but not on others.

It took a long time to load- may be acceptable- need to check compatibility with hardware (Vimba etc.) and acquisition & processing speeds.

Version tagging of generated exe files is important for traceability.

@emlynjdavies emlynjdavies added the size: 3 estimate multi-day label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size: 3 estimate multi-day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get an exe install to work
4 participants