-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow identity
, ensure dimensions
is returned, & use pre-commit.ci
#103
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 92.26% 92.27% +0.01%
==========================================
Files 26 27 +1
Lines 1357 1385 +28
==========================================
+ Hits 1252 1278 +26
- Misses 105 107 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
488311b
to
2dc605c
Compare
Ensure "identity" is respected everywhere.
f94f9ea
to
02df985
Compare
identity
key in place of uri
identity
, ensure dimensions
is returned, & use pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we could perhaps consolidate the different existing schemas for entities and make a conversion tool in the soft7 package such that we could "upgrade". That way we don't have to implement any version checking in other tools.
I fully agree with this sentiment. Indeed, issue #80 reflects part of this thought. |
This PR implements 3 things:
uri
asidentity
in entities.dimensions
is always returned.Aliasing
uri
asidentity
In the backend, the entities will still use
uri
. This is similar to the behaviour ofdims
/shape
, wheredims
is an alias forshape
andshape
is what is stored in the backend.This also means when returning the entity from the service
uri
(andshape
) will be used in place of the aliases.Ensure
dimensions
is always returnedAlways return
dimensions
from a call to the service. Even ifdimensions
is an empty list or dict/object.In the backend, if
dimensions
is empty, the key will not be stored for the given document/entity.Use pre-commit.ci
Set up configuration for pre-commit.ci usage in
.pre-commit-config.yaml
.It will run pre-commit for each PR as a CI job.
Hence, the current CI job, which runs pre-commit has been "turned off".