tests: adding group and importance markers

SSSD · Sep 13, 2023 · 2cb7bc2 · 2cb7bc2
1 parent e73efe1
commit 2cb7bc2
Show file tree

Hide file tree

Showing 13 changed files with 143 additions and 4 deletions.
diff --git a/src/tests/system/pytest.ini b/src/tests/system/pytest.ini
@@ -2,6 +2,14 @@
 addopts = --strict-markers
 testpaths = tests
 markers =
-    slow: marks tests as slow (deselect with '-m "not slow"')
-    contains_workaround_for(gh=...,bz=...): test requires workaround for an existing bug
+    authentication:
+    authorization:
+    cache:
+    contains_workaround_for(gh=...,bz=...):
+    identity:
+    schema:
+    slow:
+    tools:
 ticket_tools = bz,gh,jira
+
+# For marker descriptions please look at https://tests.sssd.io/en/latest/marks.html
diff --git a/src/tests/system/tests/test_autofs.py b/src/tests/system/tests/test_autofs.py
@@ -13,6 +13,7 @@
 from sssd_test_framework.topology import KnownTopologyGroup
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.ticket(gh=6739)
 @pytest.mark.parametrize("cache_first", [False, True])
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
@@ -60,6 +61,7 @@ def test_autofs__cache_first(client: Client, nfs: NFS, provider: GenericProvider
     }
 
 
+@pytest.mark.importance("medium")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_autofs__propagate_offline__single_domain(client: Client, provider: GenericProvider):
     """
@@ -97,6 +99,7 @@ def test_autofs__propagate_offline__single_domain(client: Client, provider: Gene
     assert offline_status_propagated
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_autofs__propagate_offline__multi_domain(client: Client):
     """
@@ -144,6 +147,7 @@ def test_autofs__propagate_offline__multi_domain(client: Client):
     assert offline_status_propagated
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_autofs__offline_domains(client: Client, nfs: NFS, provider: GenericProvider):
     """

diff --git a/src/tests/system/tests/test_config.py b/src/tests/system/tests/test_config.py
@@ -11,6 +11,7 @@
 from sssd_test_framework.topology import KnownTopologyGroup
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_config__change_config_while_sssd_running(client: Client):
     """
@@ -46,6 +47,8 @@ def test_config__change_config_while_sssd_running(client: Client):
     assert result["cn=pam,cn=config"]["debug_level"] == ["1"]
 
 
+@pytest.mark.importance("critical")
+@pytest.mark.config
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_config__genconf_particular_section(client: Client):
     """
@@ -91,6 +94,7 @@ def test_config__genconf_particular_section(client: Client):
     assert result["cn=nss,cn=config"]["debug_level"] == ["9"]
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_config__add_remove_section(client: Client):
     """
@@ -149,6 +153,7 @@ def test_config__add_remove_section(client: Client):
         assert result["cn=new_section,cn=config"]["key"] != ["value"]
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_config__genconf_no_such_section(client: Client):
     """

diff --git a/src/tests/system/tests/test_id.py b/src/tests/system/tests/test_id.py
@@ -12,6 +12,7 @@
 from sssd_test_framework.topology import KnownTopologyGroup
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_id__getpwnam(client: Client, provider: GenericProvider):
     """
@@ -44,6 +45,7 @@ def test_id__getpwnam(client: Client, provider: GenericProvider):
         assert result.user.id == uid, f"User id {result.user.id} is incorrect, {uid} expected"
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_id__getpwuid(client: Client, provider: GenericProvider):
     """
@@ -76,6 +78,7 @@ def test_id__getpwuid(client: Client, provider: GenericProvider):
         assert result.user.id == uid, f"User id {result.user.id} is incorrect, {uid} expected"
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_id__getgrnam(client: Client, provider: GenericProvider):
     """
@@ -108,6 +111,7 @@ def test_id__getgrnam(client: Client, provider: GenericProvider):
         assert result.gid == gid, f"Group gid {result.gid} is incorrect, {gid} expected"
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_id__getgrgid(client: Client, provider: GenericProvider):
     """
@@ -140,6 +144,7 @@ def test_id__getgrgid(client: Client, provider: GenericProvider):
         assert result.gid == gid, f"Group gid {result.gid} is incorrect, {gid} expected"
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_id__getent_passwd(client: Client, provider: GenericProvider):
     """
@@ -181,6 +186,7 @@ def test_id__getent_passwd(client: Client, provider: GenericProvider):
         assert result.uid == uid, f"User id {result.uid} is incorrect, {uid} expected"
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_id__getent_group(client: Client, provider: GenericProvider):
     """
@@ -220,6 +226,7 @@ def test_id__getent_group(client: Client, provider: GenericProvider):
         assert result.gid == id, f"Group gid {result.gid} is incorrect, {id} expected"
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_id__membership_by_group_name(client: Client, provider: GenericProvider):
     """
@@ -252,6 +259,7 @@ def test_id__membership_by_group_name(client: Client, provider: GenericProvider)
         assert result.memberof(groups), f"User {name} is member of wrong groups"
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_id__membership_by_group_id(client: Client, provider: GenericProvider):
     """
@@ -285,6 +293,7 @@ def test_id__membership_by_group_id(client: Client, provider: GenericProvider):
         assert result.memberof(gids), f"User {name} is member of wrong groups"
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_id__initgroups(client: Client, provider: GenericProvider):
     """
@@ -323,6 +332,7 @@ def test_id__initgroups(client: Client, provider: GenericProvider):
         assert result.memberof([10001, 10002, 10003]), f"User {name} is member of wrong groups"
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_id__getpwnam_fully_qualified_names(client: Client, provider: GenericProvider):
     """
@@ -365,6 +375,7 @@ def test_id__getpwnam_fully_qualified_names(client: Client, provider: GenericPro
     assert result.user.id == 10002, f"User id {result.user.id} is incorrect, 10002 expected"
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_id__case_insensitive(client: Client, provider: GenericProvider):
     """
@@ -409,6 +420,7 @@ def test_id__case_insensitive(client: Client, provider: GenericProvider):
         assert result.user.id == uid, f"User id {result.user.id} is incorrect, {uid} expected"
 
 
+@pytest.mark.importance("critical")
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 def test_id__fq_names_case_insensitive(client: Client, provider: GenericProvider):
     """

diff --git a/src/tests/system/tests/test_kcm.py b/src/tests/system/tests/test_kcm.py
@@ -15,6 +15,8 @@
 from sssd_test_framework.topology import KnownTopology
 
 
+@pytest.mark.importance("critical")
+@pytest.mark.authentication
 @pytest.mark.topology(KnownTopology.Client)
 @pytest.mark.parametrize("ccache_storage", ["memory", "secdb"])
 def test_kcm__kinit_overwrite(client: Client, kdc: KDC, ccache_storage: str):
@@ -61,6 +63,8 @@ def test_kcm__kinit_overwrite(client: Client, kdc: KDC, ccache_storage: str):
             assert krb.cache_count() == 1
 
 
+@pytest.mark.importance("critical")
+@pytest.mark.authentication
 @pytest.mark.topology(KnownTopology.Client)
 @pytest.mark.parametrize("ccache_storage", ["memory", "secdb"])
 def test_kcm__kinit_collection(client: Client, kdc: KDC, ccache_storage: str):
@@ -150,6 +154,8 @@ def test_kcm__kinit_collection(client: Client, kdc: KDC, ccache_storage: str):
             assert krb.cache_count() == 0
 
 
+@pytest.mark.importance("critical")
+@pytest.mark.authentication
 @pytest.mark.topology(KnownTopology.Client)
 @pytest.mark.parametrize("ccache_storage", ["memory", "secdb"])
 def test_kcm__kswitch(client: Client, kdc: KDC, ccache_storage: str):
@@ -218,6 +224,8 @@ def test_kcm__kswitch(client: Client, kdc: KDC, ccache_storage: str):
             assert krb.has_tickets("bob", kdc.realm, [kdc.tgt, kdc.qualify("host/bob")])
 
 
+@pytest.mark.importance("critical")
+@pytest.mark.authentication
 @pytest.mark.topology(KnownTopology.Client)
 @pytest.mark.parametrize("ccache_storage", ["memory", "secdb"])
 def test_kcm__subsidiaries(client: Client, kdc: KDC, ccache_storage: str):
@@ -293,6 +301,8 @@ def test_kcm__subsidiaries(client: Client, kdc: KDC, ccache_storage: str):
             assert principals[kdc.qualify("bob")] == expected[kdc.qualify("bob")]
 
 
+@pytest.mark.importance("critical")
+@pytest.mark.authentication
 @pytest.mark.topology(KnownTopology.Client)
 @pytest.mark.parametrize("ccache_storage", ["memory", "secdb"])
 def test_kcm__kdestroy_nocache(client: Client, kdc: KDC, ccache_storage: str):
@@ -327,6 +337,8 @@ def test_kcm__kdestroy_nocache(client: Client, kdc: KDC, ccache_storage: str):
                 assert False, f"kdestroy raised an error: {e}"
 
 
+@pytest.mark.importance("critical")
+@pytest.mark.authentication
 @pytest.mark.topology(KnownTopology.Client)
 def test_kcm__tgt_renewal(client: Client, kdc: KDC):
     """

diff --git a/src/tests/system/tests/test_ldap.py b/src/tests/system/tests/test_ldap.py
@@ -12,6 +12,8 @@
 from sssd_test_framework.topology import KnownTopology
 
 
+@pytest.mark.importance("critical")
+@pytest.mark.authentication
 @pytest.mark.parametrize("modify_mode", ["exop", "ldap_modify"])
 @pytest.mark.topology(KnownTopology.LDAP)
 def test_ldap__change_password(client: Client, ldap: LDAP, modify_mode: str):

diff --git a/src/tests/system/tests/test_ldap_extra_attrs.py b/src/tests/system/tests/test_ldap_extra_attrs.py
@@ -12,6 +12,8 @@
 from sssd_test_framework.topology import KnownTopologyGroup
 
 
+@pytest.mark.importance("high")
+@pytest.mark.schema
 @pytest.mark.ticket(gh=4153, bz=1362023)
 @pytest.mark.topology(KnownTopologyGroup.AnyProvider)
 @pytest.mark.parametrize("attrs", ["mail, firstname:givenname, lastname:sn", "given_email:mail"])