UTILS: swap order of seteuid()/setegid()

Otherwise it fails with: ``` 6906 16:40:32.455571 setresuid(-1, 996, -1) = 0 6906 16:40:32.455590 setresgid(-1, 993, -1) = -1 EPERM (Operation not permitted) ``` Reviewed-by: Alejandro López <[email protected]> Reviewed-by: Iker Pedrosa <[email protected]>
SSSD · Aug 9, 2023 · fcfffb5 · fcfffb5
1 parent 91d32fe
commit fcfffb5
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/src/util/usertools.c b/src/util/usertools.c
@@ -860,29 +860,30 @@ void sss_set_sssd_user_eid(void)
 
     if (geteuid() == 0) {
         sss_sssd_user_uid_and_gid(&uid, &gid);
-        if (seteuid(uid) != EOK) {
-            DEBUG(SSSDBG_MINOR_FAILURE,
-                  "Failed to set euid to %"SPRIuid": %s\n",
-                  uid, sss_strerror(errno));
-        }
+
         if (setegid(gid) != EOK) {
-            DEBUG(SSSDBG_MINOR_FAILURE,
+            DEBUG(SSSDBG_IMPORTANT_INFO,
                   "Failed to set egid to %"SPRIgid": %s\n",
                   gid, sss_strerror(errno));
         }
+        if (seteuid(uid) != EOK) {
+            DEBUG(SSSDBG_IMPORTANT_INFO,
+                  "Failed to set euid to %"SPRIuid": %s\n",
+                  uid, sss_strerror(errno));
+        }
     }
 }
 
 void sss_restore_sssd_user_eid(void)
 {
     if (getuid() == 0) {
         if (seteuid(getuid()) != EOK) {
-            DEBUG(SSSDBG_MINOR_FAILURE,
+            DEBUG(SSSDBG_IMPORTANT_INFO,
                   "Failed to restore euid: %s\n",
                   sss_strerror(errno));
         }
         if (setegid(getgid()) != EOK) {
-            DEBUG(SSSDBG_MINOR_FAILURE,
+            DEBUG(SSSDBG_IMPORTANT_INFO,
                   "Failed to restore egid: %s\n",
                   sss_strerror(errno));
         }