Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: converted tests/multihost/basic/test_ldap.py to system/tests/test_ldap.py #6805

Closed
wants to merge 1 commit into from

Conversation

patriki01
Copy link
Contributor

Another tests converted.
This pr required for this test:
SSSD/sssd-test-framework#18

Look forward to your feedback

Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add assert messages to make clear what is going on.

src/tests/system/tests/test_ldap.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_ldap.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

Copy link
Member

@pbrezina pbrezina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Patrik, see small comments inside.

src/tests/system/tests/test_ldap.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_ldap.py Show resolved Hide resolved
src/tests/system/tests/test_ldap.py Show resolved Hide resolved
src/tests/system/tests/test_ldap.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_ldap.py Outdated Show resolved Hide resolved
@pbrezina
Copy link
Member

Framework PR was merged, re-running tests.

@pbrezina
Copy link
Member

Pushed PR: #6805

  • master
    • fe61c45 - tests: converted multihost/basic/test_ldap.py
  • sssd-2-9
    • 8335284 - tests: converted multihost/basic/test_ldap.py

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Jul 31, 2023
@pbrezina pbrezina closed this Jul 31, 2023
@patriki01 patriki01 deleted the ldap_password branch August 16, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants