Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop supporting libini older than 1.3 #6923

Closed
wants to merge 1 commit into from
Closed

Stop supporting libini older than 1.3 #6923

wants to merge 1 commit into from

Conversation

alexey-tikhonov
Copy link
Member

1.3 it out since 2016

@alexey-tikhonov alexey-tikhonov added Waiting for review no-backport This should go to target branch only. labels Sep 12, 2023
@alexey-tikhonov alexey-tikhonov changed the title Stop supportning libini older than 1.3 Stop supporting libini older than 1.3 Sep 12, 2023
@alexey-tikhonov
Copy link
Member Author

Configuration script allowed anything starting 0.6 while actual code was expecting 1.1 or newer.
This is main trigger for this PR.
But since touching this area anyway, why not to force 1.3...

@ikerexxe
Copy link
Contributor

test_config_check.c, sssctl_config.c and sssctl.c also contain filtered code for libini. Why don't you remove the filtering?

@alexey-tikhonov
Copy link
Member Author

test_config_check.c, sssctl_config.c and sssctl.c also contain filtered code for libini. Why don't you remove the filtering?

Missed it. I'll fix, thanks.

ikerexxe
ikerexxe approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for taking into consideration my comment.

@alexey-tikhonov
Copy link
Member Author

Rebased and also removed

This feature is available if SSSD was compiled with libini version 1.3.0 or later.

sentence from the man page.

@alexey-tikhonov
Stop supporting libini older than 1.3
18de8f7 
1.3 it out since 2016

:relnote: SSSD now requires libini not older than v1.3
sumit-bose
sumit-bose approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thank you for the fixes, ACK.

bye,
Sumit

@alexey-tikhonov
Copy link
Member Author

Pushed PR: #6923

  • master
    • 086e46f - Stop supporting libini older than 1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikerexxe ikerexxe ikerexxe approved these changes

@sumit-bose sumit-bose sumit-bose approved these changes

Assignees

@ikerexxe ikerexxe

@sumit-bose sumit-bose

Labels
no-backport This should go to target branch only. Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexey-tikhonov @ikerexxe @sumit-bose