Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: removing intg tests, test_resolver.py #7588

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danlavu
Copy link

@danlavu danlavu commented Sep 12, 2024

dropping these dns resolution sanity tests. these tests do not test sssd at all but the test environment.

dropping these dns resolution sanity tests. these tests do not test sssd
at all but the test environment.
Copy link
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these tests covering the SSSD gethostbyname and getnetbyname interfaces? Do we have enough coverage with existing system tests for this?

@justin-stephenson
Copy link
Contributor

justin-stephenson commented Sep 19, 2024

These are SSSD NSS interfaces for hosts and network nsswitch lookups, it seems these interfaces and tests were added by Suse in 2019. I removed my ack based on this, to ensure we have test coverage for these interfaces even though we are not using them in typical sssd use cases.

System tests with 'sss' added to hosts and network lines of /etc/nsswitch.conf could be used to provide some coverage for this.

@spoore1
Copy link
Contributor

spoore1 commented Sep 19, 2024

These are SSSD NSS interfaces for hosts and network nsswitch lookups, it seems these interfaces and tests were added by Suse in 2019. I removed my ack based on this, to ensure we have test coverage for these interfaces even though we are not using them in typical sssd use cases.

System tests with 'sss' added to hosts and network lines of /etc/nsswitch.conf could be used to provide some coverage for this.

A little more digging and after talking to @danlavu , we may have coverage here:
https://github.com/SSSD/sssd/blob/master/src/tests/multihost/alltests/test_hosts.py

@justin-stephenson
Copy link
Contributor

@scabrero

@danlavu
Copy link
Author

danlavu commented Sep 19, 2024

@scabrero

For some context, we're doing some housekeeping with our tests and moving them to our new framework. We're happy to move them, but we may drop them if they're not used.

@scabrero
Copy link
Contributor

@scabrero

For some context, we're doing some housekeeping with our tests and moving them to our new framework. We're happy to move them, but we may drop them if they're not used.

Hi @danlavu, yes, it is used because after dropping nss_ldap it is the way to lookup hosts and networks stored in LDAP. I am happy to help if there is any problem migrating the tests.

@alexey-tikhonov
Copy link
Member

we may have coverage here:
https://github.com/SSSD/sssd/blob/master/src/tests/multihost/alltests/test_hosts.py

Multihost tests aren't run in upstream PR CI

@danlavu
Copy link
Author

danlavu commented Sep 20, 2024

@alexey-tikhonov That's right; we recently removed the basic tests. Alright, I'm going to defer this PR until we move the tests to system tests.

@scabrero Thank you, I don't forsee any problems moving the tests but will reach out if we do have any problems.

@danlavu danlavu marked this pull request as draft October 3, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants