rpm: drop the --remote argument from git-archive call #7639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that current (autumn 2024) git releases somehow dislike the use of `--remote=file://` when it applies the [safe] directory checks. The option doesn't seem to be useful though, so let's drop it to fix the Copr builds. Relates: fedora-copr/copr#3421
pbrezina
approved these changes
Oct 14, 2024
pbrezina
added
Accepted
backport-to-stable
branch: sssd-2-8
Ready to push
|
Ok, it works locally, let's see if it works in copr. |
|
Works, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that current (autumn 2024) git releases somehow dislike
the use of
--remote=file://when it applies the [safe] directorychecks. The option doesn't seem to be useful though, so let's drop
it to fix the Copr builds.
Relates: fedora-copr/copr#3421