Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix spellos in configure.ac #7655

Closed
wants to merge 1 commit into from
Closed

Conversation

jengelh
Copy link
Contributor

@jengelh jengelh commented Oct 18, 2024

"safe" is the antonym to "unsafe", but it's not like CFLAGS is unsafe. You really want "saved" here.

Fixes: sssd-1_13_1-169-g6b01dae73

@jengelh jengelh marked this pull request as draft October 18, 2024 11:04
@jengelh
Copy link
Contributor Author

jengelh commented Oct 18, 2024

going to wait for #7656 before rebasing.

@alexey-tikhonov
Copy link
Member

going to wait for #7656 before rebasing.

@jengelh, #7656 was merged.

"safe" is the antonym to "unsafe", but it's not like CFLAGS is unsafe.
You really want "saved" here.

Fixes: sssd-1_13_1-169-g6b01dae73
@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Oct 29, 2024

@jengelh, if this is ready, could you please move out of "Draft"?

Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexey-tikhonov
Copy link
Member

Pushed PR: #7655

  • master
    • 93eb073 - build: fix spellos in configure.ac
  • sssd-2-10
    • 42e800e - build: fix spellos in configure.ac
  • sssd-2-9
    • eb37202 - build: fix spellos in configure.ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants