SSH: sss_ssh_knownhosts must ignore DNS errors #7670
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the DNS cannot resolve the provided hostname, sss_ssh_knownhosts must not fail. Instead it should try its best to find it. It will now try to find the host account in IPA using both the fqdn and serverHostName attributes (the later contains the shortname); and using the name and nameAlias when looking for the host in the cache. However, the IP address is not (and must not be) stored in the cache or IPA entries, so this case will not work if the DNS fails to associate a hostname to the provided IP address. In such a situtation, not key will be retrieved and provided to `ssh`. Resolves: SSSD#7664
alexey-tikhonov
added
Accepted
Ready to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the DNS cannot resolve the provided hostname,
sss_ssh_knownhostsmust not fail.Instead it should try its best to find it. It will now try to find the host account in IPA using both the
fqdnandserverHostNameattributes (the latter contains the shortname); and using thenameandnameAliasattributes when looking for the host in the cache.However, the IP address is not (and must not be) stored in the cache or IPA entries, so this case will not work if the DNS fails to associate a hostname to the provided IP address. In such a situation, no key will be retrieved and provided to
ssh.Resolves: #7664