Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ ♻️ Fixed image extensions and names 4 #9180

Merged
merged 10 commits into from
Sep 15, 2024
Merged

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Sep 14, 2024

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ SSWConsulting/SSW.Rules#1431

  1. What was changed?

✏️ Changed the image extension to lowercase and formatting

  1. Did you do pair or mob programming (list names)?

✏️ No

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Sep 14, 2024
Copy link
Contributor

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 15
Total 15

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title ♻️ Fixed image extensions and names 4 XS✔ ◾ ♻️ Fixed image extensions and names 4 Sep 14, 2024
Copy link
Contributor

Hi @babakamyljanovssw,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/do-you-have-a-dress-code/rule.md Line 68: column count Rule MD056
rules/do-you-use-the-correct-input-type/rule.md Line 20: should have alternate text (alt text) Rule MD045
rules/do-you-use-the-correct-input-type/rule.md Line 31: should have alternate text (alt text) Rule MD045

Please review and update your Markdown files accordingly.

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Sep 14, 2024
@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Sep 15, 2024
Copy link
Contributor

Howzit @babakamyljanovssw,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@bradystroud bradystroud merged commit 8c78243 into main Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants