Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ 📷 Updated CheckExtensionCase workflow for image extensions #9215

Merged
merged 20 commits into from
Sep 20, 2024
Merged

XS✔ ◾ 📷 Updated CheckExtensionCase workflow for image extensions #9215

merged 20 commits into from
Sep 20, 2024

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Sep 19, 2024 •
edited
Loading

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ SSWConsulting/SSW.Rules#1431

  1. What was changed?

✏️ Updated step to check for JPG and PNG

  1. Did you do pair or mob programming (list names)?

✏️ N/A

@babakamyljanovssw babakamyljanovssw changed the title 📷 Added step to check-images workflow for image extensions 📷 WIP - Added step to check-images workflow for image extensions Sep 19, 2024
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

PR Metrics

✔ Thanks for keeping your pull request small.
✔ Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 18
Total 18

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title 📷 WIP - Added step to check-images workflow for image extensions XS✔ ◾ 📷 WIP - Added step to check-images workflow for image extensions Sep 19, 2024
@babakamyljanovssw babakamyljanovssw changed the title XS✔ ◾ 📷 WIP - Added step to check-images workflow for image extensions XS✔ ◾ 📷 Added step to check-images workflow for image extensions Sep 19, 2024
@babakamyljanovssw babakamyljanovssw changed the title XS✔ ◾ 📷 Added step to check-images workflow for image extensions XS✔ ◾ 📷 Updated CheckExtensionCase workflow for image extensions Sep 19, 2024
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old labels Sep 19, 2024
@babakamyljanovssw babakamyljanovssw mentioned this pull request Sep 20, 2024
Closed
1 task
JackDevAU
JackDevAU approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@JackDevAU JackDevAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - but I think we might also need validation on the image upload as well (in saw.rules)

@babakamyljanovssw babakamyljanovssw merged commit 467db6c into main Sep 20, 2024
4 checks passed
@babakamyljanovssw babakamyljanovssw deleted the prevent-image-extension branch September 20, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackDevAU JackDevAU JackDevAU approved these changes

@bradystroud bradystroud Awaiting requested review from bradystroud

Assignees
No one assigned
Labels
Age: 🐓 - Old About 32 hours old
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babakamyljanovssw @JackDevAU