Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added Giscus discussions and reactions #1579

Merged
merged 18 commits into from
Oct 23, 2024
Merged

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Oct 18, 2024

Relates to #1567

  • Added Giscus package
  • Added Giscus discussion on top of Disqus comments
    As per this comment ✨ Added giscus integration #1382 (comment) from old PR that adds Giscus, Adam suggested we have Giscus and Disqus for now.
  • Removed custom <Reactions /> component and it's css
  • Mapped discussion with rule using GUID, and I was able add reaction to rule locally (please see screenshot below)
  • Added GitHub secrets

Also, to link existing discussions from the Chewing the Fat, we can add computed sha1 of rule GUID to the discussion body in below format.
<!-- sha1: dcbb7fedfd3bd7f69fe677a3d5e60a6f211646ba -->

image
Figure: Giscus is added on top of Disqus

@JackDevAU
Copy link
Member

As per this comment #1382 (comment) from old PR that adds Giscus, Adam suggested we have Giscus and Disqus for now.

Not sure this is amazing.... but I understand we don't want to lose the information... Can we hide Disqus it for now and slowly add it back later?

Copy link
Member

@JackDevAU JackDevAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babakamyljanovssw babakamyljanovssw merged commit 079efd6 into main Oct 23, 2024
5 checks passed
@babakamyljanovssw babakamyljanovssw deleted the 1567-giscus branch October 23, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants