Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of BatchedInferencePipeline #1135

Merged
merged 8 commits into from
Nov 17, 2024

Conversation

MahmoudAshraf97
Copy link
Collaborator

@MahmoudAshraf97 MahmoudAshraf97 commented Nov 13, 2024

This PR aims to further refine BatchedInferencePipeline class to include more transcription options and other improvements

Summary:

  • Supported new options for batched transcriptions:
    • temperature
    • hotwords
    • fixed initial prompt
  • moved generate_segment_batched function from WhisperModel to BatchedInferencePipeline
  • make the pipeline class stateless
  • clarified documentation about what arguments do not have an effect in batched transcription

@MahmoudAshraf97 MahmoudAshraf97 force-pushed the add_hotwords_batched branch 2 times, most recently from 5bd6008 to cea8e19 Compare November 14, 2024 10:44
@MahmoudAshraf97 MahmoudAshraf97 marked this pull request as ready for review November 14, 2024 14:47
@carolinaxxxxx
Copy link

@MahmoudAshraf97 i check git+https://github.com/MahmoudAshraf97/faster-whisper.git@add_hotwords_batched and get error:

".../faster_whisper/transcribe.py", in line 487, in transcribe
if not self.model.is_multilingual and language != "en":
AttributeError: 'WhisperModel' object has no attribute 'is_multilingual'

@MahmoudAshraf97
Copy link
Collaborator Author

fixed

@carolinaxxxxx
Copy link

carolinaxxxxx commented Nov 15, 2024

@MahmoudAshraf97 i got another error after update:

"...faster_whisper/transcribe.py", line 545, in transcribe
all_language_probs=all_language_probs,
UnboundLocalError: local variable 'all_language_probs' referenced before assignment

@MahmoudAshraf97
Copy link
Collaborator Author

@MahmoudAshraf97 i got another error after update:

"...faster_whisper/transcribe.py", line 545, in transcribe
all_language_probs=all_language_probs,
UnboundLocalError: local variable 'all_language_probs' referenced before assignment

Should be fixed

@MahmoudAshraf97 MahmoudAshraf97 merged commit be9fb36 into SYSTRAN:master Nov 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants