Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct seek value in output, fix word timestamps when the initial timestamp is not zero #1141

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

heimoshuiyu
Copy link
Contributor

this fix #1140

code from commit before #856

time_offset = (
segments[0]["seek"]
* self.feature_extractor.hop_length
/ self.feature_extractor.sampling_rate
)

Copy link
Collaborator

@MahmoudAshraf97 MahmoudAshraf97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've made some additional fixes to address the core issue.

@MahmoudAshraf97 MahmoudAshraf97 changed the title fix: incorrect time_offset value fix: Use correct seek value in output, fix word timestamps when the initial timestamp is not zero Nov 15, 2024
@MahmoudAshraf97 MahmoudAshraf97 merged commit 53bbe54 into SYSTRAN:master Nov 15, 2024
3 checks passed
@Purfview
Copy link
Contributor

Finally faster-whisper is fixed after that #856 mess. Good job!

BitSteve added a commit to cresta/faster-whisper that referenced this pull request Nov 15, 2024
fix: Use correct `seek` value in output, fix word timestamps when the initial timestamp is not zero (SYSTRAN#1141)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some segment has a 1 second shifted after PR #856
3 participants