Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct some type-hints in
transcribe.py
andvad.py
files. The majority of the changes are intranscribe.py
. The idea is to make it easier to understand and maintain in the future.Did you consider creating data classes for more function returns, or can it be overwhelming?
Two type hints could be more problematic, I didn't touch them because it could change the transcribe logic, breaking it:
dict
is introduced and is expected to be alist
ofdicts
:merge_punctuations(alignment, prepend_punctuations, append_punctuations)
list
ofdicts
is expected, but alist
oflist
is introduced, but with a list of list the function shouldn't work...PD:
Thank you for contributing to the open-source community!