Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORCA-297] Fixing tutorial demo (demo.py and documentation) #35

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

jaymedina
Copy link
Contributor

@jaymedina jaymedina commented Jan 12, 2024

problem

The initial problem was the demo.py was failing at step: monitor_synstage due to it still pointing at the old nf-synstage workflow which runs with DSL1 which is no longer supported:

image

Further blockers involved failures at step monitor_rnaseq. More context in solution below.


solution

  • Point demo.py to the new synstage.nf workflow in the nf-synapse repository.
  • Fix S3 AccessDenied error by changing s3_prefix in example to a bucket that DPE tower/tower-dev workspaces have access to, and adding a caveat that the s3_prefix should be accessible by the tower workspace you're launching from.
  • Mention in documentation that NF_SYNSTAGE workflow runs should have unique names (i.e. no consecutive runs of my_test_dataset_synstage with a _# tacked on at the end). Otherwise, this will lead to consecutive steps breaking because the samplesheet can't be found.
  • Co-authored with @BWMac : Fix incorrect directory path in get_staged_samplesheet
  • Update documentation in README.md and demo.py

testing & preview

With the changes noted above, all steps up until monitor_synindex pass, which is expected behavior ✅ :

image

source


out of scope

It has been discovered that the current demo.py is not written to support getting staged samplesheets from consecutive runs of synstage with the same run name, due to the way the names are updated (e.g. my_test_dataset_synstage_2, my_test_dataset_synstage_3, etc.

This is out of scope but is a nice-to-have, low priority item that can be moved to the bottom of the backlog. In the meantime, documentation will be updated in this PR to notify users that runs of NF_SYNSTAGE should have unique names.


This is a blocker for IBCDPE-749 and therefore high in urgency 🔥

@jaymedina jaymedina self-assigned this Jan 12, 2024
Copy link

swarmia bot commented Jan 12, 2024

✅  Linked to Story ORCA-297 · Update py-orca's demo.py

@jaymedina jaymedina changed the title Fixing demo.py [ORCA-297] Fixing demo.py Jan 12, 2024
@jaymedina jaymedina added the bug Something isn't working label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (433e7ae) 100.00% compared to head (0517118) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #35   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          920       920           
  Branches       140       140           
=========================================
  Hits           920       920           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Nice!

@jaymedina jaymedina changed the title [ORCA-297] Fixing demo.py [ORCA-297] Fixing tutorial demo (demo.py and documentation) Jan 16, 2024
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jaymedina jaymedina marked this pull request as ready for review January 18, 2024 01:27
@jaymedina jaymedina requested a review from a team as a code owner January 18, 2024 01:27
Copy link
Collaborator

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 this is great! If my memory serves me right, the synindex steps fails right now - eventually we will make it all work!

@jaymedina jaymedina requested a review from BWMac January 18, 2024 14:45
@jaymedina jaymedina merged commit d15c5b7 into main Jan 18, 2024
11 checks passed
@jaymedina jaymedina deleted the ORCA-297-update-demo branch January 18, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants