-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ORCA-297] Fixing tutorial demo (demo.py
and documentation)
#35
Conversation
✅ Linked to Story ORCA-297 · Update py-orca's demo.py |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 920 920
Branches 140 140
=========================================
Hits 920 920 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Nice!
demo.py
demo.py
and documentation)
1c1fbaf
to
6b04014
Compare
a44b053
to
48e45a2
Compare
Co-authored-by: Brad Macdonald <[email protected]>
48e45a2
to
0517118
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 this is great! If my memory serves me right, the synindex steps fails right now - eventually we will make it all work!
problem
The initial problem was the
demo.py
was failing at step:monitor_synstage
due to it still pointing at the oldnf-synstage
workflow which runs with DSL1 which is no longer supported:Further blockers involved failures at step
monitor_rnaseq
. More context in solution below.solution
demo.py
to the newsynstage.nf
workflow in thenf-synapse
repository.s3_prefix
in example to a bucket that DPE tower/tower-dev workspaces have access to, and adding a caveat that the s3_prefix should be accessible by the tower workspace you're launching from.NF_SYNSTAGE
workflow runs should have unique names (i.e. no consecutive runs ofmy_test_dataset_synstage
with a_#
tacked on at the end). Otherwise, this will lead to consecutive steps breaking because the samplesheet can't be found.get_staged_samplesheet
testing & preview
With the changes noted above, all steps up until
monitor_synindex
pass, which is expected behavior ✅ :source
out of scope
It has been discovered that the current
demo.py
is not written to support getting staged samplesheets from consecutive runs ofsynstage
with the same run name, due to the way the names are updated (e.g.my_test_dataset_synstage_2
,my_test_dataset_synstage_3
, etc.This is out of scope but is a nice-to-have, low priority item that can be moved to the bottom of the backlog. In the meantime, documentation will be updated in this PR to notify users that runs of
NF_SYNSTAGE
should have unique names.This is a blocker for IBCDPE-749 and therefore high in urgency 🔥