Prevents Scheduled Workflow From Being Deactivated & [IBCDPE-898] Fix Python Versioning Issue for CI #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BWMac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Github by default will disable scheduled Actions on repositories that have had no commits for >50 days. This presents a problem for repos such as
fs-synapsewhich are still actively used but may not have frequent commits. When the workflow is deactivated, it also prevents normal runs from happening when you push new changes to a PR or intomainuntil you reactivate it.Solution:
Add the keepalive-workflow to our CI pipeline to prevent our scheduled action from ever becoming paused.
IBCDPE-898
Problem:
Similar to
py-orca, this repository was initially setup incorrectly withtox, causing the test environments created by the CI pipeline to use the wrong Python versions.Solution:
Implement the same fix as here to enable testing with the correct Python versions in GitHub Actions.
Notes:
fs-synapse. There are a number of subscripted types in the type-hints of the package and I figured this made more sense than making the changes needed to support 3.8, especially given that this will be included in the newfs-synapsemajor version