upgrade to v2 of ecr login action

Sage-Bionetworks · Nov 14, 2024 · 64a14f1 · 64a14f1
1 parent 40dfd8d
commit 64a14f1
Showing 1 changed file with 5 additions and 10 deletions.
diff --git a/.github/workflows/upload-and-deploy.yaml b/.github/workflows/upload-and-deploy.yaml
@@ -192,15 +192,10 @@ jobs:
 
       - name: Login to Amazon ECR
         id: login-ecr
-        uses: aws-actions/amazon-ecr-login@v1
+        uses: aws-actions/amazon-ecr-login@v2
+        with:
+          mask-password: 'false'
 
-      - name: Get ECR secret names
-        id: ecr
-        run: |
-          usernameKey=docker_username_$(echo ${{ steps.login-ecr.outputs.registry }} | tr '.-' _)
-          echo "username-key=$usernameKey" >> $GITHUB_OUTPUT
-          passwordKey=docker_password_$(echo ${{ steps.login-ecr.outputs.registry }} | tr '.-' _)
-          echo "password-key=$passwordKey" >> $GITHUB_OUTPUT
       - uses: actions/checkout@v3
 
       - name: Set up Docker Buildx
@@ -217,8 +212,8 @@ jobs:
           cache-to: type=local,dest=/tmp/.buildx-cache
     outputs:
       ecr-registry: ${{ steps.login-ecr.outputs.registry }}
-      ecr-username: ${{ steps.login-ecr.outputs[steps.ecr.outputs.username-key] }}
-      ecr-password: ${{ steps.login-ecr.outputs[steps.ecr.outputs.password-key] }}
+      ecr-username: ${{ steps.login-ecr.outputs['docker_username_' + steps.login-ecr.outputs.registry] }}
+      ecr-password: ${{ steps.login-ecr.outputs['docker_password_' + steps.login-ecr.outputs.registry] }}
 
   glue-unit-tests:
     name: Run Pytest unit tests for AWS glue