Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(openchallenges): add e2e tests to test paginator resetting #2589

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

rrchai
Copy link
Contributor

@rrchai rrchai commented Mar 22, 2024

Changelog

  • add e2e test to check if the paginator is resetting to 1 if any filter changes
  • disable "Mobile Safari" browser, or a timeout error will occur
  • ignore test-results folder created during PlayWright automatic code generating

Preview

Note

In order to pass the e2e test, the full stack of the app must be started before running the tests

> nx serve-detach openchallenges-apex
> nx run openchallenges-app:e2e  [local cache]


 >  NX   Ensuring Playwright is installed.

   use --skipInstall to skip installation.
[WebServer] Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme
[WebServer] - Generating browser application bundles (phase: setup)...
[WebServer] ✔ Browser application bundle generation complete.


Running 8 tests using 4 workers
[WebServer] 
Warning: /workspaces/sage-monorepo/libs/openchallenges/challenge-search/src/lib/challenge-search.component.ts depends on 'lodash'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies


[WebServer] ✔ Browser application bundle generation complete.
[WebServer] 
Warning: /workspaces/sage-monorepo/libs/openchallenges/org-search/src/lib/org-search.component.ts depends on 'lodash'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
[WebServer] 

[WebServer] ✔ Browser application bundle generation complete.
  8 passed (14.2s)

To open last HTML report run:

  npx playwright show-report


 —————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Successfully ran target e2e for project openchallenges-app (426ms)

@rrchai rrchai added the sonar-scan-approved-deprecated Ready for Sonar code analysis label Mar 22, 2024
@rrchai rrchai self-assigned this Mar 22, 2024
@rrchai rrchai marked this pull request as ready for review March 27, 2024 15:54
Copy link

sonarcloud bot commented Mar 27, 2024

Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (remember to start the stack first before running the tests)

@tschaffter tschaffter merged commit 5e08d9f into Sage-Bionetworks:main Mar 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sonar-scan-approved-deprecated Ready for Sonar code analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Test that the paginator behave as expected on the challenge search page (e2e)
2 participants