updates tests

Sage-Bionetworks · Sep 27, 2024 · 2dbb55d · 2dbb55d
1 parent dea9244
commit 2dbb55d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/synapseclient/core/download/download_async.py b/synapseclient/core/download/download_async.py
@@ -214,6 +214,7 @@ def _generate_chunk_ranges(
 def _pre_signed_url_expiration_time(url: str) -> datetime:
     """
     Returns time at which a presigned url will expire
+    for an AWS S3 pre-signed url
 
     Arguments:
         url: A pre-signed download url from AWS

diff --git a/tests/unit/synapseclient/core/download/unit_test_download_async.py b/tests/unit/synapseclient/core/download/unit_test_download_async.py
@@ -133,6 +133,7 @@ async def test_pre_signed_url_expiration_time(self) -> None:
             "&X-Amz-Expires=86400"
             "&X-Amz-SignedHeaders=host"
             "&X-Amz-Signature=signature-value"
+            "&Expires=1715000000"
         )
 
         expected = (

diff --git a/tests/unit/synapseclient/core/unit_test_download.py b/tests/unit/synapseclient/core/unit_test_download.py
@@ -834,8 +834,8 @@ async def test_download_md5_mismatch_local_file(self) -> None:
             assert not mocked_remove.called
 
     async def test_download_expired_url(self, syn: Synapse) -> None:
-        url = "http://www.ayy.lmao/filerino.txt?Expires=0"
-        new_url = "http://www.ayy.lmao/new_url.txt?Expires=1715000000"
+        url = "http://www.ayy.lmao/filerino.txt?Expires=0&X-Amz-Date=20240509T180000Z&X-Amz-Expires=1000"
+        new_url = "http://www.ayy.lmao/new_url.txt?Expires=1715000000&X-Amz-Date=20240509T180000Z&X-Amz-Expires=1000"
         contents = "\n".join(str(i) for i in range(1000))
         temp_destination = os.path.normpath(
             os.path.expanduser("~/fake/path/filerino.txt.temp")