Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add artificial delay (DEVOPS-20063) #6

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

mshepet
Copy link

@mshepet mshepet commented Nov 7, 2024

This adds an artificial delay to the VSO. Some services (such as AWS IAM) are eventually consistent and require some time between generating the secret, and using the secret.

Without this delay our services can't access AWS for a short while immediately after the secret rotation happens.

@mshepet mshepet changed the title Add artificial delay Add artificial delay (DEVOPS-20063) Nov 7, 2024
@ebdekock
Copy link

ebdekock commented Nov 8, 2024

Urgh, I'm sorry, I see in this doc: https://salesloft.atlassian.net/wiki/spaces/DEVOPS/pages/3998482447/Vault
I had linked to the correct commit, but the command was still the old commit. I have now updated the doc. Would it be possible to cherry-pick this comment instead: b191546

It has an event emitter as well. Sorry about that!

This adds an artificial delay to the VSO. Some services (such as AWS IAM)
are eventually consistent and require some time between generating
the secret, and using the secret.

Without this delay our services can't access AWS for a short while
immediately after the secret rotation happens.
@mshepet
Copy link
Author

mshepet commented Nov 8, 2024

Urgh, I'm sorry, I see in this doc: https://salesloft.atlassian.net/wiki/spaces/DEVOPS/pages/3998482447/Vault I had linked to the correct commit, but the command was still the old commit. I have now updated the doc. Would it be possible to cherry-pick this comment instead: b191546

It has an event emitter as well. Sorry about that!

no worries, I reset my branch back to the original tag and then cherry-picked b191546 and then force pushed to here.

Copy link

@ebdekock ebdekock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda lame that their tests no longer work and seem to need their infra to run

@mshepet mshepet merged commit 394bcea into salesloft/v0.9.0 Nov 11, 2024
21 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants